fix(table): master cell preview drawer interaction [AS-801]#72
Closed
pigarevaoks wants to merge 1 commit intomainfrom
Closed
fix(table): master cell preview drawer interaction [AS-801]#72pigarevaoks wants to merge 1 commit intomainfrom
pigarevaoks wants to merge 1 commit intomainfrom
Conversation
- Remove preview toggle button, open drawer by clicking master cell - Add controlled mode: `previewRowId` + `onPreviewRowChange` props - DrawerHeader always renders DrawerClose, DrawerTitle only with title - Add MasterCellWithPreviewDrawer story - Fix duplicate DrawerClose (DrawerHeader already includes one) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
61ad1b9 to
4da8c75
Compare
Collaborator
Author
|
Moved to feat/AS-801-table-preview-drawer branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
previewRowId+onPreviewRowChangepropsDrawerHeaderalways shows close button,DrawerTitleonly when title providedmodal={false},overlay={false},closeOnOutsideClick={false}data-preview-activeMasterCellWithPreviewDrawerTest plan
renderPreviewContentwithouttitle→ only close button in header🤖 Generated with Claude Code