Skip to content

fix: refetch should wait for page component to start streaming #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rmarscher wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

fix: refetch should wait for page component to start streaming #1516

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
be8b665
e2e test for #1437
rmarscher Jul 9, 2025
db69626
Merge branch 'main' into fix/refetch-await-page-streaming
rmarscher Aug 13, 2025
578b044
Merge branch 'main' into fix/refetch-await-page-streaming
rmarscher Aug 18, 2025
6104a64
Merge branch 'main' into fix/refetch-await-page-streaming
rmarscher Aug 20, 2025
96a9105
Merge branch 'main' into fix/refetch-await-page-streaming
rmarscher Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions e2e/create-pages.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,9 @@
page.getByRole('heading', { name: 'Long Suspense Page 1' }),
).toBeVisible();
await page.click("a[href='/long-suspense/2']");
await page.waitForFunction(

Check failure on line 172 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on macos-latest (Node 24.0.0) - (4/4)

[webkit-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  1) [webkit-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ──────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      170 |     ).toBeVisible();
      171 |     await page.click("a[href='/long-suspense/2']");
    > 172 |     await page.waitForFunction(
          |                ^
      173 |       () => {
      174 |         const pathname = window.location.pathname;
      175 |         const pendingElement = document.querySelector(
        at /Users/runner/work/waku/waku/e2e/create-pages.spec.ts:172:16

Check failure on line 172 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on macos-latest (Node 24.0.0) - (1/4)

[chromium-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  2) [chromium-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      170 |     ).toBeVisible();
      171 |     await page.click("a[href='/long-suspense/2']");
    > 172 |     await page.waitForFunction(
          |                ^
      173 |       () => {
      174 |         const pathname = window.location.pathname;
      175 |         const pendingElement = document.querySelector(
        at /Users/runner/work/waku/waku/e2e/create-pages.spec.ts:172:16

Check failure on line 172 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on ubuntu-latest (Node 22.12.0) - (3/4)

[webkit-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  2) [webkit-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ──────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      170 |     ).toBeVisible();
      171 |     await page.click("a[href='/long-suspense/2']");
    > 172 |     await page.waitForFunction(
          |                ^
      173 |       () => {
      174 |         const pathname = window.location.pathname;
      175 |         const pendingElement = document.querySelector(
        at /home/runner/work/waku/waku/e2e/create-pages.spec.ts:172:16

Check failure on line 172 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on ubuntu-latest (Node 22.12.0) - (3/4)

[firefox-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  1) [firefox-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ─────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      170 |     ).toBeVisible();
      171 |     await page.click("a[href='/long-suspense/2']");
    > 172 |     await page.waitForFunction(
          |                ^
      173 |       () => {
      174 |         const pathname = window.location.pathname;
      175 |         const pendingElement = document.querySelector(
        at /home/runner/work/waku/waku/e2e/create-pages.spec.ts:172:16

Check failure on line 172 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on ubuntu-latest (Node 22.12.0) - (4/4)

[webkit-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  1) [webkit-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ──────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      170 |     ).toBeVisible();
      171 |     await page.click("a[href='/long-suspense/2']");
    > 172 |     await page.waitForFunction(
          |                ^
      173 |       () => {
      174 |         const pathname = window.location.pathname;
      175 |         const pendingElement = document.querySelector(
        at /home/runner/work/waku/waku/e2e/create-pages.spec.ts:172:16

Check failure on line 172 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on macos-latest (Node 24.0.0) - (2/4)

[firefox-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  1) [firefox-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ─────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      170 |     ).toBeVisible();
      171 |     await page.click("a[href='/long-suspense/2']");
    > 172 |     await page.waitForFunction(
          |                ^
      173 |       () => {
      174 |         const pathname = window.location.pathname;
      175 |         const pendingElement = document.querySelector(
        at /Users/runner/work/waku/waku/e2e/create-pages.spec.ts:172:16

Check failure on line 172 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on ubuntu-latest (Node 20.19.0) - (4/4)

[webkit-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  1) [webkit-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ──────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      170 |     ).toBeVisible();
      171 |     await page.click("a[href='/long-suspense/2']");
    > 172 |     await page.waitForFunction(
          |                ^
      173 |       () => {
      174 |         const pathname = window.location.pathname;
      175 |         const pendingElement = document.querySelector(
        at /home/runner/work/waku/waku/e2e/create-pages.spec.ts:172:16

Check failure on line 172 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on macos-latest (Node 24.0.0) - (3/4)

[webkit-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  2) [webkit-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ──────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      170 |     ).toBeVisible();
      171 |     await page.click("a[href='/long-suspense/2']");
    > 172 |     await page.waitForFunction(
          |                ^
      173 |       () => {
      174 |         const pathname = window.location.pathname;
      175 |         const pendingElement = document.querySelector(
        at /Users/runner/work/waku/waku/e2e/create-pages.spec.ts:172:16

Check failure on line 172 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on macos-latest (Node 24.0.0) - (3/4)

[firefox-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  1) [firefox-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ─────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      170 |     ).toBeVisible();
      171 |     await page.click("a[href='/long-suspense/2']");
    > 172 |     await page.waitForFunction(
          |                ^
      173 |       () => {
      174 |         const pathname = window.location.pathname;
      175 |         const pendingElement = document.querySelector(
        at /Users/runner/work/waku/waku/e2e/create-pages.spec.ts:172:16

Check failure on line 172 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on ubuntu-latest (Node 24.0.0) - (4/4)

[webkit-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  1) [webkit-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ──────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      170 |     ).toBeVisible();
      171 |     await page.click("a[href='/long-suspense/2']");
    > 172 |     await page.waitForFunction(
          |                ^
      173 |       () => {
      174 |         const pathname = window.location.pathname;
      175 |         const pendingElement = document.querySelector(
        at /home/runner/work/waku/waku/e2e/create-pages.spec.ts:172:16

Check failure on line 172 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on ubuntu-latest (Node 20.19.0) - (3/4)

[webkit-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  2) [webkit-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ──────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      170 |     ).toBeVisible();
      171 |     await page.click("a[href='/long-suspense/2']");
    > 172 |     await page.waitForFunction(
          |                ^
      173 |       () => {
      174 |         const pathname = window.location.pathname;
      175 |         const pendingElement = document.querySelector(
        at /home/runner/work/waku/waku/e2e/create-pages.spec.ts:172:16

Check failure on line 172 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on ubuntu-latest (Node 24.0.0) - (3/4)

[webkit-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  2) [webkit-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ──────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      170 |     ).toBeVisible();
      171 |     await page.click("a[href='/long-suspense/2']");
    > 172 |     await page.waitForFunction(
          |                ^
      173 |       () => {
      174 |         const pathname = window.location.pathname;
      175 |         const pendingElement = document.querySelector(
        at /home/runner/work/waku/waku/e2e/create-pages.spec.ts:172:16

Check failure on line 172 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on ubuntu-latest (Node 24.0.0) - (3/4)

[firefox-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  1) [firefox-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ─────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      170 |     ).toBeVisible();
      171 |     await page.click("a[href='/long-suspense/2']");
    > 172 |     await page.waitForFunction(
          |                ^
      173 |       () => {
      174 |         const pathname = window.location.pathname;
      175 |         const pendingElement = document.querySelector(
        at /home/runner/work/waku/waku/e2e/create-pages.spec.ts:172:16
() => {
const pathname = window.location.pathname;
const pendingElement = document.querySelector(
'[data-testid="long-suspense-pending"]',
);
Expand All @@ -179,6 +180,7 @@
);
return (
pendingElement?.textContent === 'Pending...' &&
pathname === '/long-suspense/1' &&
heading?.textContent === 'Long Suspense Page 1'
);
},
Expand All @@ -194,13 +196,22 @@
page.getByRole('heading', { name: 'Long Suspense Page 2' }),
).not.toBeVisible();
await expect(page.getByTestId('long-suspense')).toHaveText('Loading...');
await page.waitForFunction(

Check failure on line 199 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on ubuntu-latest (Node 24.0.0) - (1/4)

[chromium-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  2) [chromium-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      197 |     ).not.toBeVisible();
      198 |     await expect(page.getByTestId('long-suspense')).toHaveText('Loading...');
    > 199 |     await page.waitForFunction(
          |                ^
      200 |       () => {
      201 |         const pathname = window.location.pathname;
      202 |         return pathname === '/long-suspense/2';
        at /home/runner/work/waku/waku/e2e/create-pages.spec.ts:199:16

Check failure on line 199 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on ubuntu-latest (Node 24.0.0) - (1/4)

[chromium-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  1) [chromium-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      197 |     ).not.toBeVisible();
      198 |     await expect(page.getByTestId('long-suspense')).toHaveText('Loading...');
    > 199 |     await page.waitForFunction(
          |                ^
      200 |       () => {
      201 |         const pathname = window.location.pathname;
      202 |         return pathname === '/long-suspense/2';
        at /home/runner/work/waku/waku/e2e/create-pages.spec.ts:199:16

Check failure on line 199 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on ubuntu-latest (Node 24.0.0) - (2/4)

[firefox-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  1) [firefox-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ─────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      197 |     ).not.toBeVisible();
      198 |     await expect(page.getByTestId('long-suspense')).toHaveText('Loading...');
    > 199 |     await page.waitForFunction(
          |                ^
      200 |       () => {
      201 |         const pathname = window.location.pathname;
      202 |         return pathname === '/long-suspense/2';
        at /home/runner/work/waku/waku/e2e/create-pages.spec.ts:199:16

Check failure on line 199 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on ubuntu-latest (Node 22.12.0) - (1/4)

[chromium-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  2) [chromium-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      197 |     ).not.toBeVisible();
      198 |     await expect(page.getByTestId('long-suspense')).toHaveText('Loading...');
    > 199 |     await page.waitForFunction(
          |                ^
      200 |       () => {
      201 |         const pathname = window.location.pathname;
      202 |         return pathname === '/long-suspense/2';
        at /home/runner/work/waku/waku/e2e/create-pages.spec.ts:199:16

Check failure on line 199 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on ubuntu-latest (Node 22.12.0) - (1/4)

[chromium-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  1) [chromium-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      197 |     ).not.toBeVisible();
      198 |     await expect(page.getByTestId('long-suspense')).toHaveText('Loading...');
    > 199 |     await page.waitForFunction(
          |                ^
      200 |       () => {
      201 |         const pathname = window.location.pathname;
      202 |         return pathname === '/long-suspense/2';
        at /home/runner/work/waku/waku/e2e/create-pages.spec.ts:199:16

Check failure on line 199 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on macos-latest (Node 24.0.0) - (1/4)

[chromium-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  1) [chromium-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      197 |     ).not.toBeVisible();
      198 |     await expect(page.getByTestId('long-suspense')).toHaveText('Loading...');
    > 199 |     await page.waitForFunction(
          |                ^
      200 |       () => {
      201 |         const pathname = window.location.pathname;
      202 |         return pathname === '/long-suspense/2';
        at /Users/runner/work/waku/waku/e2e/create-pages.spec.ts:199:16

Check failure on line 199 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on ubuntu-latest (Node 20.19.0) - (1/4)

[chromium-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  2) [chromium-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      197 |     ).not.toBeVisible();
      198 |     await expect(page.getByTestId('long-suspense')).toHaveText('Loading...');
    > 199 |     await page.waitForFunction(
          |                ^
      200 |       () => {
      201 |         const pathname = window.location.pathname;
      202 |         return pathname === '/long-suspense/2';
        at /home/runner/work/waku/waku/e2e/create-pages.spec.ts:199:16

Check failure on line 199 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on ubuntu-latest (Node 20.19.0) - (1/4)

[chromium-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  1) [chromium-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      197 |     ).not.toBeVisible();
      198 |     await expect(page.getByTestId('long-suspense')).toHaveText('Loading...');
    > 199 |     await page.waitForFunction(
          |                ^
      200 |       () => {
      201 |         const pathname = window.location.pathname;
      202 |         return pathname === '/long-suspense/2';
        at /home/runner/work/waku/waku/e2e/create-pages.spec.ts:199:16

Check failure on line 199 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on ubuntu-latest (Node 20.19.0) - (2/4)

[firefox-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  1) [firefox-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ─────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      197 |     ).not.toBeVisible();
      198 |     await expect(page.getByTestId('long-suspense')).toHaveText('Loading...');
    > 199 |     await page.waitForFunction(
          |                ^
      200 |       () => {
      201 |         const pathname = window.location.pathname;
      202 |         return pathname === '/long-suspense/2';
        at /home/runner/work/waku/waku/e2e/create-pages.spec.ts:199:16

Check failure on line 199 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on ubuntu-latest (Node 22.12.0) - (2/4)

[firefox-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  1) [firefox-dev] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ─────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      197 |     ).not.toBeVisible();
      198 |     await expect(page.getByTestId('long-suspense')).toHaveText('Loading...');
    > 199 |     await page.waitForFunction(
          |                ^
      200 |       () => {
      201 |         const pathname = window.location.pathname;
      202 |         return pathname === '/long-suspense/2';
        at /home/runner/work/waku/waku/e2e/create-pages.spec.ts:199:16

Check failure on line 199 in e2e/create-pages.spec.ts

View workflow job for this annotation

GitHub Actions / E2E on ubuntu-latest (Node 20.19.0) - (3/4)

[firefox-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense 

  1) [firefox-prd] › e2e/create-pages.spec.ts:164:3 › create-pages › long suspense ─────────────────
    TimeoutError: page.waitForFunction: Timeout 1000ms exceeded.

      197 |     ).not.toBeVisible();
      198 |     await expect(page.getByTestId('long-suspense')).toHaveText('Loading...');
    > 199 |     await page.waitForFunction(
          |                ^
      200 |       () => {
      201 |         const pathname = window.location.pathname;
      202 |         return pathname === '/long-suspense/2';
        at /home/runner/work/waku/waku/e2e/create-pages.spec.ts:199:16
() => {
const pathname = window.location.pathname;
return pathname === '/long-suspense/2';
},
undefined,
{ timeout: 1000 },
);
await expect(page.getByTestId('long-suspense-pending')).toHaveCount(0);
await expect(
page.getByRole('heading', { name: 'Long Suspense Page 3' }),
).toBeVisible();
await page.click("a[href='/long-suspense/2']");
await page.waitForFunction(
() => {
const pathname = window.location.pathname;
const pendingElement = document.querySelector(
'[data-testid="long-suspense-pending"]',
);
Expand All @@ -209,6 +220,7 @@
);
return (
pendingElement?.textContent === 'Pending...' &&
pathname === '/long-suspense/3' &&
heading?.textContent === 'Long Suspense Page 3'
);
},
Expand Down
Loading