Set HeaderExtensionsToNegotiate after negotiation by alvestrand · Pull Request #238 · w3c/webrtc-extensions

alvestrand · 2025-08-14T08:28:36Z

Fixes #237

index.html

youennf · 2025-08-28T14:05:58Z

Are there some existing WPT tests or should we add some?

This changes HeaderExtensionsToNegotiate to remember the result of the last negotiation. Corresponding spec change: w3c/webrtc-extensions#238 Bug: webrtc:439514253 Change-Id: I420b65f252398b1bb72d1938c48dc548ec18fd60 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/404946 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45493}

alvestrand · 2025-09-04T07:20:15Z

There are some existing WPT tests that need modification (because they test the previous behaviour). I'm looking into that.

youennf · 2025-09-11T14:12:35Z

index.html

-          <p>Set {{RTCRtpTransceiver/[[HeaderExtensionsToNegotiate]]}} to the
+          <p>If transceivers of the same kind exist in the current PeerConnection,
+            copy {{RTCRtpTransceiver/[[HeaderExtensionsToNegotiate]]}} from
+            the first such transceiver.


This is a bit vague, we could use how https://w3c.github.io/webrtc-pc/#dom-peerconnection-gettranseceivers is defining the list of transceivers.

this RTCPeerConnection object's set of transceivers, in insertion order.

I went with a reference to [=CollectTransceivers=], should be non-vague....

alvestrand · 2025-09-11T14:24:49Z

Note: Find an example header extension that has to be consistent for all media sections on a transport (BUNDLE).

index.html

youennf · 2025-09-11T14:25:37Z

index.html

+            in a bundle,
+            and any other transceiver exists that will be included in the same bundle,
+            copy the {{RTCRtpHeaderExtensionCapability/direction}} attribute
+            for that extension from that other transceiver.


Maybe add an example to illustrate the usefulness of the mechanism

index.html

Fixes #237

alvestrand · 2025-09-23T14:12:16Z

Are there some existing WPT tests or should we add some?

I'm updating webrtc-extensions/RTCRtpTransceiver-headerExtensionControl with the new behaviors. It was testing the old ones.

This covers spec changes made in w3c/webrtc-extensions#238 Also disable the test until the spec change is implemented. Bug: webrtc:439514253 Change-Id: Iab09d39c3edd56c8218fc32d4c0bad057be6cfff

This covers spec changes made in w3c/webrtc-extensions#238 Also disable the test until the spec change is implemented. Bug: webrtc:439514253 Change-Id: Iab09d39c3edd56c8218fc32d4c0bad057be6cfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7053963 Reviewed-by: Per Kjellander <perkj@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1532197}

Spec change: w3c/webrtc-extensions#238 Chromestatus entry for change: https://chromestatus.com/feature/5135528638939136 Bug: webrtc:439514253 Change-Id: I296f2f06dd69b4e30be419b44c926acfd2722e2d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407821 Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Guido Urdaneta <guidou@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45993}

… spec changes, a=testonly Automatic update from web-platform-tests Modify headerExtensionControl test after spec changes This covers spec changes made in w3c/webrtc-extensions#238 Also disable the test until the spec change is implemented. Bug: webrtc:439514253 Change-Id: Iab09d39c3edd56c8218fc32d4c0bad057be6cfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7053963 Reviewed-by: Per Kjellander <perkj@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1532197} -- wpt-commits: 7314290de2f3fae9bc12c8c14a7b936d6b6b6000 wpt-pr: 55544

This covers spec changes made in w3c/webrtc-extensions#238 Also disable the test until the spec change is implemented. Bug: webrtc:439514253 Change-Id: Iab09d39c3edd56c8218fc32d4c0bad057be6cfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7053963 Reviewed-by: Per Kjellander <perkj@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1532197}

… spec changes, a=testonly Automatic update from web-platform-tests Modify headerExtensionControl test after spec changes This covers spec changes made in w3c/webrtc-extensions#238 Also disable the test until the spec change is implemented. Bug: webrtc:439514253 Change-Id: Iab09d39c3edd56c8218fc32d4c0bad057be6cfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7053963 Reviewed-by: Per Kjellander <perkjchromium.org> Commit-Queue: Harald Alvestrand <htachromium.org> Cr-Commit-Position: refs/heads/main{#1532197} -- wpt-commits: 7314290de2f3fae9bc12c8c14a7b936d6b6b6000 wpt-pr: 55544 UltraBlame original commit: 0e1d4ce40c612c68d56a09b7d4ea5a93d5a29659

This covers spec changes made in w3c/webrtc-extensions#238 Also disable the test until the spec change is implemented. Bug: webrtc:439514253 Change-Id: Iab09d39c3edd56c8218fc32d4c0bad057be6cfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7053963 Reviewed-by: Per Kjellander <perkj@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1532197}

Upstream commit: https://webrtc.googlesource.com/src/+/a81f50de1711ece4d4c051bc1750cbf54177240b Implement remembering HeaderExtensionsToNegotiate This changes HeaderExtensionsToNegotiate to remember the result of the last negotiation. Corresponding spec change: w3c/webrtc-extensions#238 Bug: webrtc:439514253 Change-Id: I420b65f252398b1bb72d1938c48dc548ec18fd60 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/404946 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45493}

Upstream commit: https://webrtc.googlesource.com/src/+/a81f50de1711ece4d4c051bc1750cbf54177240b Implement remembering HeaderExtensionsToNegotiate This changes HeaderExtensionsToNegotiate to remember the result of the last negotiation. Corresponding spec change: w3c/webrtc-extensions#238 Bug: webrtc:439514253 Change-Id: I420b65f252398b1bb72d1938c48dc548ec18fd60 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/404946 Reviewed-by: Per Kjellander <perkjwebrtc.org> Commit-Queue: Harald Alvestrand <htawebrtc.org> Cr-Commit-Position: refs/heads/main{#45493} UltraBlame original commit: 254abd1355697269acb2e89998e5b45972aba005

This reverts commit 4ecf297. Reason for revert: Impacted unexpected application usages Original change's description: > Default enable WebRTC-HeaderExtensionNegotiateMemory > > Spec change: w3c/webrtc-extensions#238 > > Chromestatus entry for change: https://chromestatus.com/feature/5135528638939136 > > Bug: webrtc:439514253 > Change-Id: I296f2f06dd69b4e30be419b44c926acfd2722e2d > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407821 > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#45993} Bug: webrtc:439514253, chromium:467164231 Change-Id: I95dbc8cbaf1b769ffaea291801684bc26e4b9ccb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/433102 Reviewed-by: Guido Urdaneta <guidou@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#46456}

This reverts commit 4ecf297. Reason for revert: Impacted unexpected application usages Original change's description: > Default enable WebRTC-HeaderExtensionNegotiateMemory > > Spec change: w3c/webrtc-extensions#238 > > Chromestatus entry for change: https://chromestatus.com/feature/5135528638939136 > > Bug: webrtc:439514253 > Change-Id: I296f2f06dd69b4e30be419b44c926acfd2722e2d > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407821 > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#45993} (cherry picked from commit 74d988f) Bug: webrtc:439514253, chromium:467164231 Change-Id: I95dbc8cbaf1b769ffaea291801684bc26e4b9ccb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/433102 Reviewed-by: Guido Urdaneta <guidou@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Original-Commit-Position: refs/heads/main@{#46456} No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/433485 Commit-Queue: Guido Urdaneta <guidou@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/branch-heads/7499@{#3} Cr-Branched-From: 1dfd30c-refs/heads/main@{#46046}

This reverts commit 4ecf297. Reason for revert: Impacted unexpected application usages Original change's description: > Default enable WebRTC-HeaderExtensionNegotiateMemory > > Spec change: w3c/webrtc-extensions#238 > > Chromestatus entry for change: https://chromestatus.com/feature/5135528638939136 > > Bug: webrtc:439514253 > Change-Id: I296f2f06dd69b4e30be419b44c926acfd2722e2d > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407821 > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#45993} (cherry picked from commit 74d988fd57f8f1b6722d8ac6f49c686b9f2bc196) Bug: webrtc:439514253, chromium:467164231, chromium:468332329 Change-Id: I95dbc8cbaf1b769ffaea291801684bc26e4b9ccb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/433102 Reviewed-by: Guido Urdaneta <guidou@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Original-Commit-Position: refs/heads/main@{#46456} No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/433562 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Guido Urdaneta <guidou@webrtc.org> Cr-Commit-Position: refs/branch-heads/7559@{#1} Cr-Branched-From: f680c18-refs/heads/main@{#46356}

Essentially a no-op since we're going to see this change reverted when we vendor in 4e31d1a1ff. Upstream commit: https://webrtc.googlesource.com/src/+/4ecf297a4c0af68ff8af8c3a8e6b0832bddd14d5 Default enable WebRTC-HeaderExtensionNegotiateMemory Spec change: w3c/webrtc-extensions#238 Chromestatus entry for change: https://chromestatus.com/feature/5135528638939136 Bug: webrtc:439514253 Change-Id: I296f2f06dd69b4e30be419b44c926acfd2722e2d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407821 Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Guido Urdaneta <guidou@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45993}

We already cherry-picked this when we vendored 4ecf297a4c. Upstream commit: https://webrtc.googlesource.com/src/+/4e31d1a1ff41bb1b79609c83f998458a111a149c Revert "Default enable WebRTC-HeaderExtensionNegotiateMemory" This reverts commit 4ecf297a4c0af68ff8af8c3a8e6b0832bddd14d5. Reason for revert: Impacted unexpected application usages Original change's description: > Default enable WebRTC-HeaderExtensionNegotiateMemory > > Spec change: w3c/webrtc-extensions#238 > > Chromestatus entry for change: https://chromestatus.com/feature/5135528638939136 > > Bug: webrtc:439514253 > Change-Id: I296f2f06dd69b4e30be419b44c926acfd2722e2d > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407821 > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#45993} (cherry picked from commit 74d988fd57f8f1b6722d8ac6f49c686b9f2bc196) Bug: webrtc:439514253, chromium:467164231 Change-Id: I95dbc8cbaf1b769ffaea291801684bc26e4b9ccb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/433102 Reviewed-by: Guido Urdaneta <guidou@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Original-Commit-Position: refs/heads/main@{#46456} No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/433485 Commit-Queue: Guido Urdaneta <guidou@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/branch-heads/7499@{#3} Cr-Branched-From: 1dfd30cf31a029cd127674a11e65c54c07afaf5d-refs/heads/main@{#46046}

We already cherry-picked this when we vendored 4e31d1a1ff. Upstream commit: https://webrtc.googlesource.com/src/+/49d44a2a548b307eb3184b56b5ff98ad7bfda2ba [M144] Revert "Default enable WebRTC-HeaderExtensionNegotiateMemory" This reverts commit 4ecf297a4c0af68ff8af8c3a8e6b0832bddd14d5. Reason for revert: Impacted unexpected application usages Original change's description: > Default enable WebRTC-HeaderExtensionNegotiateMemory > > Spec change: w3c/webrtc-extensions#238 > > Chromestatus entry for change: https://chromestatus.com/feature/5135528638939136 > > Bug: webrtc:439514253 > Change-Id: I296f2f06dd69b4e30be419b44c926acfd2722e2d > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407821 > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#45993} (cherry picked from commit 74d988fd57f8f1b6722d8ac6f49c686b9f2bc196) Bug: webrtc:439514253, chromium:467164231, chromium:468332329 Change-Id: I95dbc8cbaf1b769ffaea291801684bc26e4b9ccb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/433102 Reviewed-by: Guido Urdaneta <guidou@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Original-Commit-Position: refs/heads/main@{#46456} No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/433562 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Guido Urdaneta <guidou@webrtc.org> Cr-Commit-Position: refs/branch-heads/7559@{#1} Cr-Branched-From: f680c1893f3b166b370439da52ae82d02f54969c-refs/heads/main@{#46356}

This reverts commit 74d988f. Reland "Default enable WebRTC-HeaderExtensionNegotiateMemory" This reverts commit 74d988f. Reason for revert: Added code to skip stopped transceivers Original change's description: > Revert "Default enable WebRTC-HeaderExtensionNegotiateMemory" > > This reverts commit 4ecf297. > > Reason for revert: Impacted unexpected application usages > > Original change's description: > > Default enable WebRTC-HeaderExtensionNegotiateMemory > > > > Spec change: w3c/webrtc-extensions#238 > > > > Chromestatus entry for change: https://chromestatus.com/feature/5135528638939136 > > > > Bug: webrtc:439514253 > > Change-Id: I296f2f06dd69b4e30be419b44c926acfd2722e2d > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407821 > > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#45993} > > Bug: webrtc:439514253, chromium:467164231 > Change-Id: I95dbc8cbaf1b769ffaea291801684bc26e4b9ccb > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/433102 > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#46456} Bug: webrtc:439514253, chromium:467164231 Change-Id: I2df85ba25016374a52abb13037cdca74fb1a395d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/453240 Reviewed-by: Guido Urdaneta <guidou@webrtc.org> Commit-Queue: Guido Urdaneta <guidou@webrtc.org> Cr-Commit-Position: refs/heads/main@{#47038}

This reverts commit 2f06978. Reland "Default enable WebRTC-HeaderExtensionNegotiateMemory" This reverts commit 2f06978. Reason for revert: Abundance of caution - want more canary time. Original change's description: > Revert^2 "Default enable WebRTC-HeaderExtensionNegotiateMemory" > > This reverts commit 74d988f. > > Reland "Default enable WebRTC-HeaderExtensionNegotiateMemory" > > This reverts commit 74d988f. > > Reason for revert: Added code to skip stopped transceivers > > Original change's description: > > Revert "Default enable WebRTC-HeaderExtensionNegotiateMemory" > > > > This reverts commit 4ecf297. > > > > Reason for revert: Impacted unexpected application usages > > > > Original change's description: > > > Default enable WebRTC-HeaderExtensionNegotiateMemory > > > > > > Spec change: w3c/webrtc-extensions#238 > > > > > > Chromestatus entry for change: https://chromestatus.com/feature/5135528638939136 > > > > > > Bug: webrtc:439514253 > > > Change-Id: I296f2f06dd69b4e30be419b44c926acfd2722e2d > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407821 > > > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > > > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > > > Cr-Commit-Position: refs/heads/main@{#45993} > > > > Bug: webrtc:439514253, chromium:467164231 > > Change-Id: I95dbc8cbaf1b769ffaea291801684bc26e4b9ccb > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/433102 > > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#46456} > > Bug: webrtc:439514253, chromium:467164231 > Change-Id: I2df85ba25016374a52abb13037cdca74fb1a395d > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/453240 > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > Commit-Queue: Guido Urdaneta <guidou@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#47038} No-Try: True Bug: webrtc:439514253, chromium:467164231, webrtc:489813847 Change-Id: Id2151293ffe14d2238a1363dd7df679c8a27c42f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/453820 Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Guido Urdaneta <guidou@webrtc.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#47093}

This reverts commit 5f9534d. Reland "Default enable WebRTC-HeaderExtensionNegotiateMemory" This reverts commit 5f9534d. Reason for revert: M147 is now cut, landing for M148. Original change's description: > Revert^3 "Default enable WebRTC-HeaderExtensionNegotiateMemory" > > This reverts commit 2f06978. > > Reland "Default enable WebRTC-HeaderExtensionNegotiateMemory" > > This reverts commit 2f06978. > > Reason for revert: Abundance of caution - want more canary time. > > Original change's description: > > Revert^2 "Default enable WebRTC-HeaderExtensionNegotiateMemory" > > > > This reverts commit 74d988f. > > > > Reland "Default enable WebRTC-HeaderExtensionNegotiateMemory" > > > > This reverts commit 74d988f. > > > > Reason for revert: Added code to skip stopped transceivers > > > > Original change's description: > > > Revert "Default enable WebRTC-HeaderExtensionNegotiateMemory" > > > > > > This reverts commit 4ecf297. > > > > > > Reason for revert: Impacted unexpected application usages > > > > > > Original change's description: > > > > Default enable WebRTC-HeaderExtensionNegotiateMemory > > > > > > > > Spec change: w3c/webrtc-extensions#238 > > > > > > > > Chromestatus entry for change: https://chromestatus.com/feature/5135528638939136 > > > > > > > > Bug: webrtc:439514253 > > > > Change-Id: I296f2f06dd69b4e30be419b44c926acfd2722e2d > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407821 > > > > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > > > > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > > > > Cr-Commit-Position: refs/heads/main@{#45993} > > > > > > Bug: webrtc:439514253, chromium:467164231 > > > Change-Id: I95dbc8cbaf1b769ffaea291801684bc26e4b9ccb > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/433102 > > > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > > > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > > > Cr-Commit-Position: refs/heads/main@{#46456} > > > > Bug: webrtc:439514253, chromium:467164231 > > Change-Id: I2df85ba25016374a52abb13037cdca74fb1a395d > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/453240 > > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > > Commit-Queue: Guido Urdaneta <guidou@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#47038} > > No-Try: True > Bug: webrtc:439514253, chromium:467164231, webrtc:489813847 > Change-Id: Id2151293ffe14d2238a1363dd7df679c8a27c42f > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/453820 > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#47093} Bug: webrtc:439514253, chromium:467164231, webrtc:489813847 Change-Id: I5249afdfaef3bc4d72570448c33d04ff71ddec11 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/456241 Reviewed-by: Guido Urdaneta <guidou@webrtc.org> Commit-Queue: Guido Urdaneta <guidou@webrtc.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#47143}

Original change's description: > Revert^3 "Default enable WebRTC-HeaderExtensionNegotiateMemory" > > This reverts commit 2f06978. > > Reland "Default enable WebRTC-HeaderExtensionNegotiateMemory" > > This reverts commit 2f06978. > > Reason for revert: Abundance of caution - want more canary time. > > Original change's description: > > Revert^2 "Default enable WebRTC-HeaderExtensionNegotiateMemory" > > > > This reverts commit 74d988f. > > > > Reland "Default enable WebRTC-HeaderExtensionNegotiateMemory" > > > > This reverts commit 74d988f. > > > > Reason for revert: Added code to skip stopped transceivers > > > > Original change's description: > > > Revert "Default enable WebRTC-HeaderExtensionNegotiateMemory" > > > > > > This reverts commit 4ecf297. > > > > > > Reason for revert: Impacted unexpected application usages > > > > > > Original change's description: > > > > Default enable WebRTC-HeaderExtensionNegotiateMemory > > > > > > > > Spec change: w3c/webrtc-extensions#238 > > > > > > > > Chromestatus entry for change: https://chromestatus.com/feature/5135528638939136 > > > > > > > > Bug: webrtc:439514253 > > > > Change-Id: I296f2f06dd69b4e30be419b44c926acfd2722e2d > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407821 > > > > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > > > > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > > > > Cr-Commit-Position: refs/heads/main@{#45993} > > > > > > Bug: webrtc:439514253, chromium:467164231 > > > Change-Id: I95dbc8cbaf1b769ffaea291801684bc26e4b9ccb > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/433102 > > > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > > > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > > > Cr-Commit-Position: refs/heads/main@{#46456} > > > > Bug: webrtc:439514253, chromium:467164231 > > Change-Id: I2df85ba25016374a52abb13037cdca74fb1a395d > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/453240 > > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > > Commit-Queue: Guido Urdaneta <guidou@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#47038} > > No-Try: True > Bug: webrtc:439514253, chromium:467164231, webrtc:489813847 > Change-Id: Id2151293ffe14d2238a1363dd7df679c8a27c42f > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/453820 > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#47093} (cherry picked from commit 5f9534d9205a870d40aff649967a38fbde7d7653) Bug: chromium:491748676,webrtc:439514253,chromium:467164231,webrtc:489813847 Change-Id: Id2151293ffe14d2238a1363dd7df679c8a27c42f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/455980 Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7727@{#1} Cr-Branched-From: 5788235-refs/heads/main@{#47086}

We already cherry-picked this when we vendored 49d44a2a54. Upstream commit: https://webrtc.googlesource.com/src/+/74d988fd57f8f1b6722d8ac6f49c686b9f2bc196 Revert "Default enable WebRTC-HeaderExtensionNegotiateMemory" This reverts commit 4ecf297a4c0af68ff8af8c3a8e6b0832bddd14d5. Reason for revert: Impacted unexpected application usages Original change's description: > Default enable WebRTC-HeaderExtensionNegotiateMemory > > Spec change: w3c/webrtc-extensions#238 > > Chromestatus entry for change: https://chromestatus.com/feature/5135528638939136 > > Bug: webrtc:439514253 > Change-Id: I296f2f06dd69b4e30be419b44c926acfd2722e2d > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407821 > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Guido Urdaneta <guidou@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#45993} Bug: webrtc:439514253, chromium:467164231 Change-Id: I95dbc8cbaf1b769ffaea291801684bc26e4b9ccb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/433102 Reviewed-by: Guido Urdaneta <guidou@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#46456}

We already cherry-picked this when we vendored 49d44a2a54. Upstream commit: https://webrtc.googlesource.com/src/+/74d988fd57f8f1b6722d8ac6f49c686b9f2bc196 Revert "Default enable WebRTC-HeaderExtensionNegotiateMemory" This reverts commit 4ecf297a4c0af68ff8af8c3a8e6b0832bddd14d5. Reason for revert: Impacted unexpected application usages Original change's description: > Default enable WebRTC-HeaderExtensionNegotiateMemory > > Spec change: w3c/webrtc-extensions#238 > > Chromestatus entry for change: https://chromestatus.com/feature/5135528638939136 > > Bug: webrtc:439514253 > Change-Id: I296f2f06dd69b4e30be419b44c926acfd2722e2d > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407821 > Commit-Queue: Harald Alvestrand <htawebrtc.org> > Reviewed-by: Guido Urdaneta <guidouwebrtc.org> > Cr-Commit-Position: refs/heads/main{#45993} Bug: webrtc:439514253, chromium:467164231 Change-Id: I95dbc8cbaf1b769ffaea291801684bc26e4b9ccb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/433102 Reviewed-by: Guido Urdaneta <guidouwebrtc.org> Commit-Queue: Harald Alvestrand <htawebrtc.org> Cr-Commit-Position: refs/heads/main{#46456} UltraBlame original commit: 70503d0b87b7c9daec2e8862480b211cf4fae3ba

youennf reviewed Aug 21, 2025

View reviewed changes

index.html Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

henbos added the needs-test label Aug 28, 2025

youennf reviewed Sep 11, 2025

View reviewed changes

youennf approved these changes Sep 11, 2025

View reviewed changes

jan-ivar reviewed Sep 11, 2025

View reviewed changes

index.html Outdated Show resolved Hide resolved

youennf reviewed Sep 11, 2025

View reviewed changes

jan-ivar approved these changes Sep 11, 2025

View reviewed changes

index.html Show resolved Hide resolved

youennf added the editors can integrate label Sep 11, 2025

alvestrand added 4 commits September 23, 2025 15:39

Set HeaderExtensionsToNegotiate after negotiation

6e443a8

Fixes #237

Also initialize new transceivers

129b3e5

Add transport-consistent initialization

8178166

Review comment fix

f2f8bd0

Minor tweaks and notes

1623cd9

alvestrand force-pushed the renegotiate-header-extensions branch from 4f2b661 to 1623cd9 Compare September 23, 2025 14:52

Fix reference error

1970624

alvestrand merged commit ccc0614 into main Sep 25, 2025
2 checks passed

alvestrand deleted the renegotiate-header-extensions branch September 25, 2025 09:44

chromium-wpt-export-bot mentioned this pull request Oct 20, 2025

Modify headerExtensionControl test after spec changes web-platform-tests/wpt#55544

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set HeaderExtensionsToNegotiate after negotiation#238

Set HeaderExtensionsToNegotiate after negotiation#238
alvestrand merged 6 commits intomainfrom
renegotiate-header-extensions

alvestrand commented Aug 14, 2025 •

edited by pr-preview bot

Loading

Uh oh!

Uh oh!

Uh oh!

youennf commented Aug 28, 2025

Uh oh!

alvestrand commented Sep 4, 2025

Uh oh!

youennf Sep 11, 2025

Uh oh!

youennf Sep 11, 2025

Uh oh!

alvestrand Sep 23, 2025

Uh oh!

alvestrand commented Sep 11, 2025

Uh oh!

Uh oh!

youennf Sep 11, 2025

Uh oh!

Uh oh!

alvestrand commented Sep 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

alvestrand commented Aug 14, 2025 • edited by pr-preview bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

youennf commented Aug 28, 2025

Uh oh!

alvestrand commented Sep 4, 2025

Uh oh!

youennf Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

youennf Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

alvestrand Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

alvestrand commented Sep 11, 2025

Uh oh!

Uh oh!

youennf Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alvestrand commented Sep 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alvestrand commented Aug 14, 2025 •

edited by pr-preview bot

Loading