Add selective disclosure example and conversion pseudo code#572
Open
PatStLouis wants to merge 1 commit intomainfrom
Open
Add selective disclosure example and conversion pseudo code#572PatStLouis wants to merge 1 commit intomainfrom
PatStLouis wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
TallTed
reviewed
Dec 16, 2025
| FOR EACH pointer IN pointers: | ||
| is_deep = true | ||
| FOR EACH p IN pointers: | ||
| IF length(pointer) < length(p) AND p starts with pointer: |
Collaborator
There was a problem hiding this comment.
Note that GitHub highlighting acts on the < preceding length(p). This might need to be <.
msporny
reviewed
Dec 16, 2025
Comment on lines
+1281
to
+1282
| When implementing [=selective disclosure=] features, it is often necessary to | ||
| convert a QueryByExample `example` object into a list of JSON pointers that |
Contributor
There was a problem hiding this comment.
Suggested change
| When implementing [=selective disclosure=] features, it is often necessary to | |
| convert a QueryByExample `example` object into a list of JSON pointers that | |
| When implementing [=selective disclosure=] features, it is necessary to | |
| convert a QueryByExample `example` object into a list of JSON pointers that |
Collaborator
Author
|
Group discussed this on a call, will need to review the pseudo code and favor an "algorithm" spec section instead. This should be inspired by this issue: #574 |
Contributor
|
I need to do a more robust review, but looking at least at the prose steps here they looked right to me. I did want to note that I think the way pointers are generated for selective disclosure will be different from how they are generated for matching (and that's ok) -- there will just be two different algorithms aimed at different purposes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #545
Preview | Diff