fix(overview): keep ProjectionCard 'Revenue so far' label inside card#33
Open
Ehsan-saradar wants to merge 1 commit intomainfrom
Open
fix(overview): keep ProjectionCard 'Revenue so far' label inside card#33Ehsan-saradar wants to merge 1 commit intomainfrom
Ehsan-saradar wants to merge 1 commit intomainfrom
Conversation
When progress is high, the label was anchored to the left of the marker line and could overflow the card on the right. Detect overflow with a ResizeObserver and flip the label to the left side of the line with right-aligned text, keeping the marker line position unchanged. Closes #32 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revenue so farlabel insideProjectionCardwould overflow the card and flip it to the left side of the marker line, with right-aligned text so the text edge stays aligned with the line.left: ${progressPercent}%is preserved); only the surrounding label is re-anchored viatransform: translateX(-100%)andflex-row-reverse.ResizeObserver, so it adapts to the actual track width (betweenmin-w-[180px]andmax-w-[280px]) and the actual label width (label/value text).Closes #32
Test plan
🤖 Generated with Claude Code