Fix modals flickering on multiple modals open#8442
Closed
DlLemmA wants to merge 1 commit intovueComponent:mainfrom
Closed
Fix modals flickering on multiple modals open#8442DlLemmA wants to merge 1 commit intovueComponent:mainfrom
DlLemmA wants to merge 1 commit intovueComponent:mainfrom
Conversation
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When multiple modals are opened using
Modal.confirm, previously opened modals rerender unexpectedly due to their VNode keys changing.The root cause is that all modals share a global mutable
uuidfor keys. The render function closes over this mutable variable, so previously created modals can see the updateduuid, leading to unstable keys and unnecessary remounts.Note: Vue’s useId() cannot be used here because these modals are created imperatively, outside of component setup, which triggers a Vue warning.