Fix mempool webhook read during subaddress scanning - #283
Merged
Conversation
vtnerd
force-pushed
the
fix/subaddress_and_mempool_read
branch
from
August 7, 2026 22:40
b9fa827 to
30fa08c
Compare
Owner
Author
|
Guess I'm bumping the monero pin too, as this is difficult to change. |
vtnerd
force-pushed
the
fix/subaddress_and_mempool_read
branch
from
August 8, 2026 02:23
30fa08c to
87ec682
Compare
vtnerd
added a commit
that referenced
this pull request
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mahnunchik reported in #281 that a LMDB read error can occur when trying to lookup webhooks for mempool txes. I was able to reproduce the issue, and write a unit test that verifies the fix. So we get a bug fix + a 0-conf webhook test!
Watching the CI for this, as this has only been tested on Ubuntu 22.04.