Add SLI prober for Garage#651
Merged
github-actions[bot] merged 1 commit intodevelopfrom Apr 27, 2026
Merged
Conversation
3 tasks
TheBigLee
force-pushed
the
garage/sli_prober
branch
from
6e6fb07 to
7151bd6
Compare
Contributor
|
Contributor
|
TheBigLee
force-pushed
the
garage/sli_prober
branch
from
ff03a72 to
f335b19
Compare
Contributor
|
TheBigLee
force-pushed
the
garage/sli_prober
branch
from
f335b19 to
51aef67
Compare
Contributor
|
TheBigLee
force-pushed
the
garage/sli_prober
branch
from
51aef67 to
f216e5c
Compare
Contributor
|
TheBigLee
force-pushed
the
garage/sli_prober
branch
from
f216e5c to
8956c00
Compare
Contributor
|
TheBigLee
force-pushed
the
garage/sli_prober
branch
from
8956c00 to
5626c44
Compare
Contributor
|
There was a problem hiding this comment.
Pull request overview
This PR adds SLI probing support for the VSHNGarage service by introducing a dedicated SLI exporter controller, a new Garage probe implementation, and the required API/RBAC wiring so the exporter can create/read the supporting Garage CRs and secrets.
Changes:
- Added a new
VSHNGarageReconcilerto start/stop Garage SLIs and bootstrap required GarageBucket/GarageKey resources. - Added a new
probes.VSHNGarageimplementation that checks Garage admin health and performs an S3 write. - Updated API/CRD/RBAC and SLI exporter main to enable the new controller when the XVSHNGarage kind is available.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/sliexporter/vshngarage_controller/vshngarage_controller.go | New SLI exporter controller for XVSHNGarage; creates/deletes SLI GarageBucket/GarageKey CRs and dials the Garage probe. |
| pkg/sliexporter/vshngarage_controller/vshngarage_controller_test.go | Unit tests for probe start/stop behavior and guard conditions (startup grace, no creds, suspended). |
| pkg/sliexporter/probes/garage.go | New Garage probe: admin health check + S3 write probe, plus constructor with endpoint parsing. |
| pkg/comp-functions/functions/vshngarage/deploy.go | Enables admin key generation in the Garage deployment values. |
| apis/vshn/v1/dbaas_vshn_garage.go | Adds CompositionRef to XVSHNGarageSpec and implements XVSHNGarage getters used by the generic SLI reconciler. |
| apis/vshn/v1/zz_generated.deepcopy.go | Updates deepcopy to include the newly added CompositionRef field. |
| crds/vshn.appcat.vshn.io_xvshngarages.yaml | CRD schema update to include spec.compositionRef. |
| config/sliexporter/rbac/role.yaml | Grants SLI exporter permissions for GarageBucket/GarageKey and Garage/XVSHNGarage resources. |
| cmd/sliexporter.go | Wires up the VSHNGarage controller in the SLI exporter binary. |
| config/controller/webhooks.yaml | Removes the leading YAML document separator line. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheBigLee
force-pushed
the
garage/sli_prober
branch
from
5626c44 to
59a9105
Compare
Contributor
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheBigLee
force-pushed
the
garage/sli_prober
branch
from
59a9105 to
1b132f6
Compare
TheBigLee
requested review from
a team,
Kidswiss,
mdnix and
zugao
and removed request for
a team
Kidswiss
requested changes
Apr 23, 2026
TheBigLee
force-pushed
the
garage/sli_prober
branch
from
1b132f6 to
31a8939
Compare
Contributor
|
Contributor
|
Also typo in PR title 😬 |
TheBigLee
force-pushed
the
garage/sli_prober
branch
from
31a8939 to
c3056df
Compare
TheBigLee
force-pushed
the
garage/sli_prober
branch
from
c3056df to
a1216f3
Compare
Contributor
|
Contributor
|
Kidswiss
reviewed
Apr 23, 2026
TheBigLee
force-pushed
the
garage/sli_prober
branch
from
a1216f3 to
a1a393a
Compare
Contributor
|
TheBigLee
force-pushed
the
garage/sli_prober
branch
from
a1a393a to
a619619
Compare
Contributor
|
mikeshootzz
approved these changes
Apr 24, 2026
Contributor
mikeshootzz
left a comment
mikeshootzz
left a comment
There was a problem hiding this comment.
Think @Kidswiss already mentioned everything, rest LGTM :D
mdnix
approved these changes
Apr 24, 2026
Member
mdnix
left a comment
mdnix
left a comment
There was a problem hiding this comment.
This needs fixing: #651 (comment)
Otherwise looking good
TheBigLee
force-pushed
the
garage/sli_prober
branch
from
a619619 to
bc05b19
Compare
Contributor
|
zugao
approved these changes
Apr 27, 2026
Kidswiss
approved these changes
Apr 27, 2026
Contributor
Sleep deprivation for the win 🤪 |
TheBigLee
force-pushed
the
garage/sli_prober
branch
from
bc05b19 to
182029a
Compare
Contributor
|
Member
Author
|
/merge |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
/mergecomment.Component PR: vshn/component-appcat#1155