Support other versions of remi repo on redhat#669
Open
kobybr wants to merge 7 commits intovoxpupuli:masterfrom
Open
Support other versions of remi repo on redhat#669kobybr wants to merge 7 commits intovoxpupuli:masterfrom
kobybr wants to merge 7 commits intovoxpupuli:masterfrom
Conversation
smortex
requested changes
Oct 5, 2022
Member
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
Nice, I added some in-line comments for some points of attention and the docstrings need updating. Thanks!
smortex
added
the
backwards-incompatible
Author
|
Just checking in on this. Seems I have all the pieces in place, let me know otherwise. Thanks |
|
Just checking in, are there any more issues we need to address with this PR? |
smortex
requested changes
May 3, 2023
Member
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
Oops, I missed the notification. Just a minor hitch.
| /(?i:Amazon)/ => '6', | ||
| default => '$releasever', # Yum var | ||
| } | ||
| $version = $yum_repo.match('.\d$')[0] |
Member
There was a problem hiding this comment.
.\d$ feels weird: any char followed by a digit at the end of a line.
I guess what you mean here is any number of digits at the end of the string? \d+\z
smortex
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the class php::repo::redhat is hardcoded to create only the remi56 repo. This request removes that static value and creates based on $yum_repo. This allows for other versions such as remi_php72, etc..