read timestamp configuration#157
Open
cstkingkey wants to merge 1 commit intovolks73:mainfrom
Open
Conversation
volks73
reviewed
Jan 21, 2022
Owner
volks73
left a comment
volks73
left a comment
There was a problem hiding this comment.
@cstkingkey Nice! Would it be possible to add some tests of the new timestamp function that sets the value from the metadata? For examples, see some of the unit tests for metadata fields in the create.rs module. Nothing expansive, just something that at least tests the behavior of the function a little.
Owner
|
@cstkingkey Is this still of interest and could you add some tests to cover the new timestamp function? With the addition of some tests, I would be ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, timestamp setting in toml is not used.