fix(markdown): preserve multi-dot filenames during resource parsing#1875
Open
zexuyann wants to merge 3 commits intovolcengine:mainfrom
Open
fix(markdown): preserve multi-dot filenames during resource parsing#1875zexuyann wants to merge 3 commits intovolcengine:mainfrom
zexuyann wants to merge 3 commits intovolcengine:mainfrom
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
bf19ac5 to
65cb844
Compare
65cb844 to
416368e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a resource naming issue in OpenViking
add_resourceflow when generating filesystem folder names for filenames containing multiple dots.Previously,
Path(...).stemwas applied twice during resource name generation. For filenames such as:access.dns.a_b_c.yamlaccess.dns.a_b_d.yamlthe second stem operation incorrectly truncated the semantic suffix, causing generated filesystem folder names to collapse to values such as:
accessdnsaccessdns_1This affected the directory name used when storing parsed resources on disk during the
add_resourceprocess.This change removes the second
Path(...).stemcall and preserves the already-derived name to ensure stable filesystem folder naming.Related Issue
Type of Change
Changes Made
Path(...).stemcall inadd_resourcenaming logicTesting
Checklist
Screenshots (if applicable)
N/A
Additional Notes
Example naming flow after this change:
access.dns.app_a_b_c.yaml→
access.dns.app_a_b_c→
accessdnsapp_a_b_cThis ensures consistent filesystem folder naming during
add_resourceprocessing.