Open
Conversation
Signed-off-by: Hank Zhan <hank.zhan@broadcom.com>
Signed-off-by: Hank Zhan <hank.zhan@broadcom.com>
zhanhank
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is adding go binding for Cns Volume Control Flags (mainly for changed block tracking) APIs
1, add VolumeCBTStatus in Volume
2, add APIs SetVolumeControlFlags and ClearVolumeControlFlags
3, allow QueryVolume with CBT status
Note: will add support for simulator in following changes.
Closes: #(issue-number)
How Has This Been Tested?
bash-4.4$ go test -v -count=1 ./cns -run TestBlockVolumeCBT
=== RUN TestBlockVolumeCBT
client_test.go:2082: CBT test: created block volume "b6d0bc60-094d-46c9-b7f4-8a5e3a6d974d"
client_test.go:2149: snapshot "e9c6b988-b6aa-4822-a6fa-265fe0fd9218" changedBlockTrackingId="52 a8 9e 8f 17 3c 86 f0-08 52 f5 6e 9f bf 54 3b/1"
client_test.go:2180: snapshot "e9c6b988-b6aa-4822-a6fa-265fe0fd9218" changedBlockTrackingId="52 a8 9e 8f 17 3c 86 f0-08 52 f5 6e 9f bf 54 3b/1" (from QuerySnapshots)
--- PASS: TestBlockVolumeCBT (9.83s)
PASS
ok github.com/vmware/govmomi/cns 9.846s
Guidelines
Please read and follow the
CONTRIBUTIONguidelines of this project.