🌱 Improve visibility of pending events during VM creation - #1916
Open
bryanv wants to merge 1 commit into
Open
Conversation
bryanv
force-pushed
the
bryanv/vm-controller-emit-pending-events
branch
from
September 10, 2026 15:44
14a3a2c to
32f8a40
Compare
github-actions
Bot
added
size/M
bryanv
marked this pull request as ready for review
September 10, 2026 18:46
bryanv
force-pushed
the
bryanv/vm-controller-emit-pending-events
branch
from
September 10, 2026 18:48
32f8a40 to
c3a9d46
Compare
hpannem
reviewed
Sep 10, 2026
akutz
approved these changes
Sep 11, 2026
Somewhat confusingly we could emit multiple CreateSuccess events during the VM creation process. Also, if we are waiting for the VMIC to be ready, the VM controller logs would not indicate that, making it unclear why a reconcile was a noop. Change the suffix for NoRequeueErrors during create to be pending, since that error means we are just waiting for some external resource to be ready.
bryanv
force-pushed
the
bryanv/vm-controller-emit-pending-events
branch
from
September 11, 2026 17:16
c3a9d46 to
5b5eeed
Compare
Contributor
Minimum allowed line rate is |
hpannem
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Somewhat confusingly we could emit multiple CreateSuccess events during the VM creation process. Also, if we are waiting for the VMIC to be ready, the VM controller logs would not indicate that, making it unclear why a reconcile was a noop.
Change the suffix for NoRequeueErrors during create to be pending, since that error means we are just waiting for some external resource to be ready.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # vmop-4182
Are there any special notes for your reviewer:
Example:
I agree the message for the network not ready "errors" need to be improved but would prefer to kick those to a later MR.
Please add a release note if necessary: