Expose gdn::causal_conv1d and gdn::gated_delta_rule as standalone torch ops with unit tests#202
Draft
Expose gdn::causal_conv1d and gdn::gated_delta_rule as standalone torch ops with unit tests#202
Conversation
Copilot
AI
changed the title
[WIP] [VLLM-189] Expose and register gdn::causal_conv1d and gdn::gated_delta_rule
Expose gdn::causal_conv1d and gdn::gated_delta_rule as torch XPU ops
Mar 19, 2026
Copilot
AI
changed the title
Expose gdn::causal_conv1d and gdn::gated_delta_rule as torch XPU ops
Expose gdn::causal_conv1d and gdn::gated_delta_rule as standalone torch ops with unit tests
Mar 19, 2026
…orch ops Co-authored-by: jikunshang <50897707+jikunshang@users.noreply.github.com>
Co-authored-by: jikunshang <50897707+jikunshang@users.noreply.github.com>
3d8f049 to
a810897
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gdn::causal_conv1dandgdn::gated_delta_rulewere only accessible as internal implementation details ofgdn_attention, with no way to call them independently from Python.Changes
C++ – new wrapper functions (
gdn_attn_interface.cpp,ops.h,torch_bindings.cpp)causal_conv1dandgated_delta_ruleC++ wrapper functions that forward directly togdn::causal_conv1d/gdn::gated_delta_ruletorch.ops._xpu_CviaTORCH_LIBRARY_EXPAND, following the same pattern asgdn_attentionPython – unit tests (
tests/gdn_attn/)test_causal_conv1d.py: reference impl (ref_causal_conv1d) + parametrised test covering prefill/decode/mix modes, bias/no-bias,reorder_input=True/False; validates all six output tensors (q, k, v, z, b, a) and updatedconv_statestest_gated_delta_rule.py: reference impl (ref_gated_delta_rule) + parametrised test covering all modes; validatescore_attn_outand updatedssm_stateUsage
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.