[BUG FIX]: prevent EngineCore crash when Qwen TTS Base task is missing ref_text#2203
Open
teith wants to merge 3 commits intovllm-project:mainfrom
Open
[BUG FIX]: prevent EngineCore crash when Qwen TTS Base task is missing ref_text#2203teith wants to merge 3 commits intovllm-project:mainfrom
teith wants to merge 3 commits intovllm-project:mainfrom
Conversation
Contributor
|
Do we need to add test cases for this scenario? @linyueqian |
Collaborator
yes, it would be great. |
Collaborator
|
fix pre-commit please |
Collaborator
|
fix dco please |
4babda6 to
152f1b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single malformed request to
/v1/audio/speechwithtask_type=Baseand noref_textkills the entireEngineCore. All subsequent requests — including valid ones — fail withEngineDeadError.Reproduce:
serve:
vllm-omni serve Qwen/Qwen3-TTS-12Hz-1.7B-Base --omni --trust-remote-code --host 0.0.0.0 --port 8000 --enforce-eagerRoot cause:
_build_prompt_embeds()raisesValueErrorwhenref_textis missing in ICL mode. vLLM v1 treats any worker exception as fatal.Fix:
serving_speech.py: validateref_textpresence for Base task before the request reaches the engine (returns HTTP 400)qwen3_tts_talker.py: fall back tox-vector-onlymode instead of raising, matching the existing non-ICL codepath (protects offline inference and other entrypoints)