[Enhancement] Support RunAI Model Streamer for diffusion weight loading#2199
Open
NickCao wants to merge 1 commit intovllm-project:mainfrom
Open
[Enhancement] Support RunAI Model Streamer for diffusion weight loading#2199NickCao wants to merge 1 commit intovllm-project:mainfrom
NickCao wants to merge 1 commit intovllm-project:mainfrom
Conversation
NickCao
force-pushed
the
runai-streamer
branch
2 times, most recently
from
4e245db to
ede67f7
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ede67f76da
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Add enable_runai_streamer flag to OmniDiffusionConfig so diffusion models can use the runai_model_streamer library for streaming safetensors weights, matching the support already available in the LLM weight loading path. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Nick Cao <ncao@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add enable_runai_streamer flag to OmniDiffusionConfig so diffusion models can use the runai_model_streamer library for streaming safetensors weights, matching the support already available in the LLM weight loading path.
Test Plan
Test Result
It runs. Reducing model load time from 55.68s to 39.45s.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)