Skip to content

[Misc] DiffusionWorker, MultiprocDiffusionExecutor: cleanup unused references to zmq#2193

Open
NickCao wants to merge 3 commits intovllm-project:mainfrom
NickCao:zmq-cleanup
Open

[Misc] DiffusionWorker, MultiprocDiffusionExecutor: cleanup unused references to zmq#2193
NickCao wants to merge 3 commits intovllm-project:mainfrom
NickCao:zmq-cleanup

Conversation

@NickCao
Copy link
Contributor

@NickCao NickCao commented Mar 25, 2026

Purpose

While reading zmq related code, I noticed that zmq context is initialized in several placed but never used, thus the cleanup.

Test Plan

pytest -s -v tests/e2e/offline_inference/test_zimage_parallelism.py

Test Result

================== 2 passed, 17 warnings in 123.94s (0:02:03) ==================

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

NickCao and others added 3 commits March 25, 2026 11:54
Inter-process communication happens through vllm shm_broadcast MessageQueue

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Nick Cao <ncao@redhat.com>
Inter-process communication happens through vllm shm_broadcast MessageQueue

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Nick Cao <ncao@redhat.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Nick Cao <ncao@redhat.com>
@NickCao NickCao requested a review from hsliuustc0106 as a code owner March 25, 2026 15:58
@hsliuustc0106
Copy link
Collaborator

does it help initialization speed?

@NickCao
Copy link
Contributor Author

NickCao commented Mar 25, 2026

does it help initialization speed?

zmq Context takes no time to init, so no. But removing these unused references can prevent confusion that the workers are still using zmq for IPC while they actually are not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants