[Misc] DiffusionWorker, MultiprocDiffusionExecutor: cleanup unused references to zmq#2193
Open
NickCao wants to merge 3 commits intovllm-project:mainfrom
Open
[Misc] DiffusionWorker, MultiprocDiffusionExecutor: cleanup unused references to zmq#2193NickCao wants to merge 3 commits intovllm-project:mainfrom
NickCao wants to merge 3 commits intovllm-project:mainfrom
Conversation
Inter-process communication happens through vllm shm_broadcast MessageQueue Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Nick Cao <ncao@redhat.com>
Inter-process communication happens through vllm shm_broadcast MessageQueue Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Nick Cao <ncao@redhat.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Nick Cao <ncao@redhat.com>
Collaborator
|
does it help initialization speed? |
Contributor
Author
zmq Context takes no time to init, so no. But removing these unused references can prevent confusion that the workers are still using zmq for IPC while they actually are not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
While reading zmq related code, I noticed that zmq context is initialized in several placed but never used, thus the cleanup.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)