Skip to content

[310P][Feat.]: 310P support W8A8 dynamic linear method#7725

Open
YangShuai52 wants to merge 8 commits intovllm-project:mainfrom
YangShuai52:w8a8dynamic_linear
Open

[310P][Feat.]: 310P support W8A8 dynamic linear method#7725
YangShuai52 wants to merge 8 commits intovllm-project:mainfrom
YangShuai52:w8a8dynamic_linear

Conversation

@YangShuai52
Copy link
Copy Markdown
Contributor

@YangShuai52 YangShuai52 commented Mar 27, 2026

What this PR does / why we need it?

Does this PR introduce any user-facing change?

How was this patch tested?

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for W8A8 dynamic linear quantization on the Ascend 310P platform. This new scheme aims to improve the efficiency of linear layers by dynamically quantizing activations to 8-bit integers while keeping weights at 8-bit, leveraging specific NPU operations for computation.

Highlights

  • New Quantization Scheme: Implemented AscendW8A8DynamicLinearMethod310 to support W8A8 dynamic linear quantization specifically for the Ascend 310P.
  • Dynamic Quantization Logic: Added methods for retrieving quantized weights, per-channel parameters, and applying the dynamic quantization during the forward pass using torch_npu operations.
  • Weight Processing: Included post-loading weight processing to handle transposition, conversion to NZ format for performance, and flattening of scale/offset tensors.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the AscendW8A8DynamicLinearMethod310 class to support W8A8 dynamic quantization for linear layers on Ascend 310P hardware. The implementation includes weight allocation, per-channel parameter management, and a forward pass utilizing NPU-specific operations such as npu_dynamic_quant and npu_quant_matmul. Review feedback correctly identified that the weight_offset parameter is redundant because the current implementation only supports symmetric quantization, and it should be removed from both the allocation and post-loading processing logic.

Suggested PR Title:

[310P][Ops][Feature] Add W8A8 dynamic linear quantization for Ascend 310P

Suggested PR Summary:

### What this PR does / why we need it?
This PR adds the `AscendW8A8DynamicLinearMethod310` class to provide W8A8 dynamic quantization support for linear layers on Ascend 310P. It implements weight initialization, per-channel scaling, and the execution of quantized matrix multiplication via `torch_npu`. This is necessary to enable efficient dynamic quantization on 310P hardware.

### Does this PR introduce _any_ user-facing change?
Yes, it adds a new quantization scheme "W8A8_DYNAMIC" for linear layers on Ascend 310P.

### How was this patch tested?
CI passed with existing tests; the implementation utilizes standard NPU-specific operators.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

) -> dict[str, Any]:
return {"weight": torch.empty(output_size, input_size, dtype=torch.int8)}

def get_perchannel_param(self, output_size: int, params_dtype: torch.dtype) -> dict[str, Any]:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里也和分支保持一致吧:
def get_perchannel_param(
self,
output_size: int,
params_dtype: torch.dtype,
) -> dict[str, Any]:

更清晰一些

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@YangShuai52 YangShuai52 requested a review from wangxiyuan as a code owner March 27, 2026 09:07
Signed-off-by: YangShuai52 <yangshuai153@huawei.com>
Signed-off-by: YangShuai52 <yangshuai153@huawei.com>
Signed-off-by: YangShuai52 <yangshuai153@huawei.com>
Signed-off-by: YangShuai52 <yangshuai153@huawei.com>
Signed-off-by: YangShuai52 <yangshuai153@huawei.com>
Signed-off-by: YangShuai52 <yangshuai153@huawei.com>
Signed-off-by: YangShuai52 <yangshuai153@huawei.com>
Signed-off-by: YangShuai52 <yangshuai153@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants