[v0.18.0][Misc] Recompute scheduler upgrade to vLLM 0.18.0#7720
[v0.18.0][Misc] Recompute scheduler upgrade to vLLM 0.18.0#7720yiz-liu merged 2 commits intovllm-project:releases/v0.18.0from
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the RecomputeScheduler to maintain compatibility with the vLLM v0.18.0 release. The changes focus on aligning internal scheduling mechanisms with upstream updates, improving the robustness of request handling during asynchronous operations, and enhancing support for advanced KV cache configurations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the RecomputeScheduler in the vllm-ascend module to improve request scheduling and KV cache management. Key updates include the integration of PauseState for scheduling control, a refactored waiting request queue that utilizes a skipped requests mechanism, and improved encoder cache allocation for encoder-decoder models. The changes also ensure accurate token count tracking during asynchronous KV transfers and add support for zeroing new block IDs. I have no feedback to provide as no review comments were present. Suggested PR Title: [vllm-ascend][Scheduler][Misc] Refactor recompute scheduler and enhance KV cache handling Suggested PR Summary: markdown ### What this PR does / why we need it? This PR refactors the RecomputeScheduler to improve request handling and KV cache management. It introduces PauseState support, refactors the waiting request scheduling logic using a skipped requests queue, and updates encoder cache allocation for encoder-decoder models. Additionally, it ensures correct token count tracking during asynchronous KV transfers and adds support for zeroing new block IDs. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI passed with existing tests.
What this PR does / why we need it?
cherry-pick from #7675 .
The current RecomputeScheduler is aligned to Scheduler in vLLM v0.16.0. Since upstream vLLM has upgraded to v0.18.0, we also need to upgrade RecomputeScheduler to pick up missing updates.
Does this PR introduce any user-facing change?
How was this patch tested?