[cherry-pick][Misc] Bump modelscope version to v1.35.1#7713
[cherry-pick][Misc] Bump modelscope version to v1.35.1#7713Potabk wants to merge 1 commit intovllm-project:releases/v0.18.0from
Conversation
Signed-off-by: wangli <wangli858794774@gmail.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the modelscope dependency version to ensure the project utilizes the latest release, removing the need for installation from a fixed hash. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the modelscope dependency in requirements-dev.txt to version >=1.35.1. Feedback indicates that the PR title should be updated to include a module tag (e.g., [CI][Misc]) to comply with the repository's style guide. Additionally, it is recommended to apply the same version pin to benchmarks/requirements-bench.txt to ensure consistency across the project. Suggested PR Title: markdown [CI][Misc] Bump modelscope version to v1.35.1 Suggested PR Summary: markdown ### What this PR does / why we need it? This PR bumps the modelscope version to >=1.35.1 in the development requirements to ensure consistency and access to required features. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI passed.
| @@ -1,6 +1,6 @@ | |||
| -r requirements-lint.txt | |||
There was a problem hiding this comment.
The PR title [Misc] Bump modelscope version to v1.35.1 does not fully conform to the repository's style guide, which requires the format [Branch][Module][Action] Pull Request Title. The [Module] tag is missing. Please consider a title like [CI][Misc] Bump modelscope version to v1.35.1.
References
- The repository style guide (lines 43-61) specifies that pull request titles should follow the format
[Branch][Module][Action] Pull Request Title. TheModuletag is a required component. (link)
| -r requirements-lint.txt | ||
| -r requirements.txt | ||
| modelscope | ||
| modelscope>=1.35.1 |
What this PR does / why we need it?
Since modelscope has the newer release, we do not need install ms from a fixed hash
Does this PR introduce any user-facing change?
How was this patch tested?