Skip to content

[cherry-pick][Misc] Bump modelscope version to v1.35.1#7713

Open
Potabk wants to merge 1 commit intovllm-project:releases/v0.18.0from
Potabk:fix_ms018
Open

[cherry-pick][Misc] Bump modelscope version to v1.35.1#7713
Potabk wants to merge 1 commit intovllm-project:releases/v0.18.0from
Potabk:fix_ms018

Conversation

@Potabk
Copy link
Collaborator

@Potabk Potabk commented Mar 27, 2026

What this PR does / why we need it?

Since modelscope has the newer release, we do not need install ms from a fixed hash

Does this PR introduce any user-facing change?

How was this patch tested?

Signed-off-by: wangli <wangli858794774@gmail.com>
@Potabk Potabk requested review from Yikun and wangxiyuan as code owners March 27, 2026 03:03
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the modelscope dependency version to ensure the project utilizes the latest release, removing the need for installation from a fixed hash.

Highlights

  • Dependency Update: Updated the modelscope dependency in requirements-dev.txt to version 1.35.1 or higher.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/_e2e_test.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the modelscope dependency in requirements-dev.txt to version >=1.35.1. Feedback indicates that the PR title should be updated to include a module tag (e.g., [CI][Misc]) to comply with the repository's style guide. Additionally, it is recommended to apply the same version pin to benchmarks/requirements-bench.txt to ensure consistency across the project. Suggested PR Title: markdown [CI][Misc] Bump modelscope version to v1.35.1 Suggested PR Summary: markdown ### What this PR does / why we need it? This PR bumps the modelscope version to >=1.35.1 in the development requirements to ensure consistency and access to required features. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI passed.

@@ -1,6 +1,6 @@
-r requirements-lint.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The PR title [Misc] Bump modelscope version to v1.35.1 does not fully conform to the repository's style guide, which requires the format [Branch][Module][Action] Pull Request Title. The [Module] tag is missing. Please consider a title like [CI][Misc] Bump modelscope version to v1.35.1.

References
  1. The repository style guide (lines 43-61) specifies that pull request titles should follow the format [Branch][Module][Action] Pull Request Title. The Module tag is a required component. (link)

-r requirements-lint.txt
-r requirements.txt
modelscope
modelscope>=1.35.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The modelscope dependency is also present in benchmarks/requirements-bench.txt without a version pin. To ensure consistency and reproducible benchmarks, please update it there as well to modelscope>=1.35.1.

@wangxiyuan wangxiyuan changed the title [Misc] Bump modelscope version to v1.35.1 [cherry-pick][Misc] Bump modelscope version to v1.35.1 Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants