[Bugfix]support FlashComm1&DCP for Qwen#7673
[Bugfix]support FlashComm1&DCP for Qwen#7673Milkyyx wants to merge 7 commits intovllm-project:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a specific bug in the Qwen2.5 model implementation within the vLLM Ascend worker. It introduces a condition to prevent an overlap between the Distributed Communication Protocol (DCP) and FlashComm1 scenarios, which was causing incorrect behavior. The fix ensures that the model execution logic correctly handles these distributed communication settings. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request modifies the model_runner_v1.py file to refine the conditions for enabling CUDAGraphMode or Streaming Processor (SP). It adds self.dcp_size == 1 to the existing conditional logic, ensuring that these optimization modes are only activated when both pcp_size and dcp_size are equal to 1. This change likely improves the correctness or performance of token padding in distributed processing environments. There were no review comments to address.
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
eb203b8 to
0d48e74
Compare
730190e to
85dd6ea
Compare
Signed-off-by: Yang Yuxi <907276627@qq.com>
Signed-off-by: Yang Yuxi <907276627@qq.com>
85dd6ea to
252e5b7
Compare
Signed-off-by: Yang Yuxi <907276627@qq.com>
Signed-off-by: Yang Yuxi <907276627@qq.com>
Signed-off-by: Yang Yuxi <907276627@qq.com>
Signed-off-by: Yang Yuxi <907276627@qq.com>
Signed-off-by: Yang Yuxi <907276627@qq.com>
What this PR does / why we need it?
Fixed the issue where the DCP overlaps the FlashComm1 scenario in the Qwen2.5
Does this PR introduce any user-facing change?
No
How was this patch tested?