Skip to content

[Bugfix]support FlashComm1&DCP for Qwen#7673

Open
Milkyyx wants to merge 7 commits intovllm-project:mainfrom
Milkyyx:fix/support-flashcomm1-dcp-for-qwen
Open

[Bugfix]support FlashComm1&DCP for Qwen#7673
Milkyyx wants to merge 7 commits intovllm-project:mainfrom
Milkyyx:fix/support-flashcomm1-dcp-for-qwen

Conversation

@Milkyyx
Copy link
Copy Markdown

@Milkyyx Milkyyx commented Mar 26, 2026

What this PR does / why we need it?

Fixed the issue where the DCP overlaps the FlashComm1 scenario in the Qwen2.5

Does this PR introduce any user-facing change?

No

How was this patch tested?

@Milkyyx Milkyyx requested a review from MengqingCao as a code owner March 26, 2026 06:58
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a specific bug in the Qwen2.5 model implementation within the vLLM Ascend worker. It introduces a condition to prevent an overlap between the Distributed Communication Protocol (DCP) and FlashComm1 scenarios, which was causing incorrect behavior. The fix ensures that the model execution logic correctly handles these distributed communication settings.

Highlights

  • Qwen2.5 FlashComm1/DCP Overlap Fix: Resolved an issue where the Distributed Communication Protocol (DCP) was overlapping with the FlashComm1 scenario specifically for Qwen2.5 models, ensuring correct execution logic.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the model_runner_v1.py file to refine the conditions for enabling CUDAGraphMode or Streaming Processor (SP). It adds self.dcp_size == 1 to the existing conditional logic, ensuring that these optimization modes are only activated when both pcp_size and dcp_size are equal to 1. This change likely improves the correctness or performance of token padding in distributed processing environments. There were no review comments to address.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@Milkyyx Milkyyx force-pushed the fix/support-flashcomm1-dcp-for-qwen branch from eb203b8 to 0d48e74 Compare March 26, 2026 07:09
@Milkyyx Milkyyx changed the title [Bugfix]support FlashComm1&DCP for qwen [Bugfix]support FlashComm1&DCP for Qwen Mar 26, 2026
@Milkyyx Milkyyx force-pushed the fix/support-flashcomm1-dcp-for-qwen branch 2 times, most recently from 730190e to 85dd6ea Compare March 27, 2026 03:40
@Milkyyx Milkyyx requested a review from LCAIZJ as a code owner March 27, 2026 03:40
Milkyyx added 2 commits March 27, 2026 11:49
Signed-off-by: Yang Yuxi <907276627@qq.com>
Signed-off-by: Yang Yuxi <907276627@qq.com>
Milkyyx added 3 commits March 27, 2026 18:05
Signed-off-by: Yang Yuxi <907276627@qq.com>
Signed-off-by: Yang Yuxi <907276627@qq.com>
Signed-off-by: Yang Yuxi <907276627@qq.com>
@weiguihua2 weiguihua2 added ready read for review ready-for-test start test by label for PR labels Mar 27, 2026
@weiguihua2 weiguihua2 added this to the v0.18.0rc1 milestone Mar 27, 2026
Milkyyx added 2 commits March 27, 2026 18:35
Signed-off-by: Yang Yuxi <907276627@qq.com>
Signed-off-by: Yang Yuxi <907276627@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants