[Doc] Add issue workflow guidelines#7668
[Doc] Add issue workflow guidelines#7668zeshengzong wants to merge 5 commits intovllm-project:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive issue workflow guidelines for the vLLM Ascend project. The primary goal is to standardize how issues are managed from creation to closure, fostering clearer communication and more efficient collaboration among contributors and maintainers. By defining specific label categories and a structured workflow, the changes aim to streamline the issue resolution process and improve overall project maintainability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces new documentation outlining the issue workflow guidelines for the vLLM Ascend project, including label categories and a three-phase workflow. The review comments highlight several inconsistencies and areas for improvement within this new document. Specifically, the invalid and wontfix status labels, as well as the critical priority label, are mentioned in the workflow description but are missing from their respective definition tables. Additionally, there's a contradiction in how 'invalid' issues are handled between the mermaid diagram and the textual description, which should be aligned for clarity.
| | `triage review` | Newly filed or unseen issue awaiting initial assessment by a maintainer | | ||
| | `triaged` | Assessment complete; type, priority, and module have been determined | | ||
| | `pending` | Blocked on an external dependency or awaiting a response before work can proceed | | ||
| | `resolved` | Issue has been closed — either via a merged PR, or through non-code resolution (e.g., answered question, configuration guidance) | | ||
| | `stale` | No activity for an extended period; parties have been notified and the issue will be auto-closed if there is no response | | ||
| | `duplicated` | A duplicate of an existing open issue or merged PR | |
There was a problem hiding this comment.
The workflow description later on (lines 130-131) mentions invalid and wontfix labels, but they are not defined in this Status Labels table. This will cause confusion. Please add them to the table for clarity and consistency.
| | `triage review` | Newly filed or unseen issue awaiting initial assessment by a maintainer | | |
| | `triaged` | Assessment complete; type, priority, and module have been determined | | |
| | `pending` | Blocked on an external dependency or awaiting a response before work can proceed | | |
| | `resolved` | Issue has been closed — either via a merged PR, or through non-code resolution (e.g., answered question, configuration guidance) | | |
| | `stale` | No activity for an extended period; parties have been notified and the issue will be auto-closed if there is no response | | |
| | `duplicated` | A duplicate of an existing open issue or merged PR | | |
| | `triage review` | Newly filed or unseen issue awaiting initial assessment by a maintainer | | |
| | `triaged` | Assessment complete; type, priority, and module have been determined | | |
| | `pending` | Blocked on an external dependency or awaiting a response before work can proceed | | |
| | `resolved` | Issue has been closed — either via a merged PR, or through non-code resolution (e.g., answered question, configuration guidance) | | |
| | `stale` | No activity for an extended period; parties have been notified and the issue will be auto-closed if there is no response | | |
| | `duplicated` | A duplicate of an existing open issue or merged PR | | |
| | `invalid` | The issue report is invalid, unclear, or not reproducible | | |
| | `wontfix` | The issue will not be addressed; includes an explanation | |
There was a problem hiding this comment.
Already removed invalid and wontfix labels from description
| | `high` | High priority; should be resolved in the current or next cycle | | ||
| | `medium` | Normal priority; handled in the regular development flow | | ||
| | `low` | Low priority; edge case or minor issue that can be deferred | |
There was a problem hiding this comment.
There's an inconsistency in the priority labels. The table in this section lists high, medium, and low. However, the workflow description in Phase 2 (line 127) and the mermaid diagram (line 93) also mention a critical priority. To ensure consistency, please add the critical label to this table.
| | `high` | High priority; should be resolved in the current or next cycle | | |
| | `medium` | Normal priority; handled in the regular development flow | | |
| | `low` | Low priority; edge case or minor issue that can be deferred | | |
| | `critical` | Must be addressed immediately | | |
| | `high` | High priority; should be resolved in the current or next cycle | | |
| | `medium` | Normal priority; handled in the regular development flow | | |
| | `low` | Low priority; edge case or minor issue that can be deferred | |
There was a problem hiding this comment.
Following current priority levels, removed critical label, keep it as current status: high, medium, low
| C[Replace triage review → triaged] | ||
| C --> C2{Issue status?} | ||
| C2 -- Duplicate --> C3["Apply duplicated\nLink existing issue/PR → Close"] | ||
| C2 -- Invalid --> C4["Apply resolved\nExplain → Close"] |
There was a problem hiding this comment.
There is a contradiction in how invalid issues are handled. This diagram says to apply the resolved label, but the text description in Phase 2 (line 130) correctly says to apply an invalid label. Using invalid is more semantically correct. Please update the diagram to be consistent with the text.
| C2 -- Invalid --> C4["Apply resolved\nExplain → Close"] | |
| C2 -- Invalid --> C4["Apply invalid\nExplain → Close"] |
There was a problem hiding this comment.
The invalid label already removed, currently only need resolved label to mark issue handled by a maintainer/contributor.
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
202c1b7 to
e0e374e
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
Suggested PR Title:\n\nmarkdown\n[Doc][Misc] Add Issue Workflow Guidelines\n\n\nSuggested PR Summary:\n\nmarkdown\n### What this PR does / why we need it?\nThis PR introduces `issue-workflow-guidelines.md` to define the standard lifecycle for issues in the vLLM Ascend project, including label categories and a three-phase triage process. A review comment identifies a high-severity inconsistency between the workflow diagram and the descriptive text regarding the closure process for invalid reports and the timing of the `resolved` label application.\n\n### Does this PR introduce _any_ user-facing change?\nNo.\n\n### How was this patch tested?\nN/A (Documentation update)\n
| - Verify and apply the appropriate **issue type** label (`bug`, `feature request`, `RFC`, `question`, `documentation`, `installation`, `performance`, `new model`, etc.). | ||
| - Handle terminal states: | ||
| - For duplicates, apply the `duplicated` label, provide an explanation and a link to the existing issue or PR. If there are no further questions, close the issue. | ||
| - For invalid reports, provide an explanation and apply the `resolved` label, then wait for a response from the issue creator. If there are no further questions, close the issue. |
There was a problem hiding this comment.
There is an inconsistency in the documented process for handling invalid reports. The workflow diagram on line 69 (C -- Invalid --> C4[Add: resolved → Close]) suggests an immediate closure after applying the resolved label. However, this line states to 'wait for a response from the issue creator' before closing. This could lead to confusion. Please align the diagram and the text to describe a single, clear process.
Additionally, the description for the resolved label on line 16 says it's for an issue that 'has been closed', but this line suggests applying it before closing. This is also contradictory. Please ensure the timing of applying the label and closing the issue is consistent throughout the document.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a new documentation file, issue-workflow-guidelines.md, which outlines the standard lifecycle for issues in the vLLM Ascend project, including label definitions and a three-phase workflow. The review feedback highlights a logic error in the Mermaid diagram for the closure phase and a procedural contradiction in handling invalid reports.
Suggested PR Title:
[Doc][Feature] Add Issue Workflow GuidelinesSuggested PR Summary:
### What this PR does / why we need it?
This PR adds the `Issue Workflow Guidelines` to define the standard lifecycle for issues, ensuring consistent label usage and communication. It covers status, type, priority, and contribution labels, and details the workflow from initial response to closure. Feedback indicates the need to fix a logic error in the Phase 3 Mermaid diagram and resolve a contradiction in the invalid report handling process.
### Does this PR introduce _any_ user-facing change?
Documentation-only updates are not considered user-facing changes.
### How was this patch tested?
No code changes; documentation verified for clarity and structure.|
|
||
| subgraph P3["Phase 3 — Closure"] | ||
| direction LR | ||
| D[Track & Implement] -- Resolved --> D2[Apply: resolved → Close] -- Long inactive --> D3[Apply: stale → Auto-close] |
There was a problem hiding this comment.
The Mermaid diagram for 'Phase 3 — Closure' on line 80 incorrectly shows a sequential flow from a resolved issue to a stale issue. A resolved and closed issue should not become stale. An inactive issue becomes stale.
The flow should show two separate outcomes from the 'Track & Implement' state: one for 'Resolved' and another for 'Long inactive'.
Please correct the diagram. The definition for this part of the subgraph should be changed from:
D[Track & Implement] -- Resolved --> D2[Apply: resolved → Close] -- Long inactive --> D3[Apply: stale → Auto-close]
to something like:
D[Track & Implement]
D -- Resolved --> D2[Apply: resolved → Close]
D -- Long inactive --> D3[Apply: stale → Auto-close]
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Zesheng Zong <zesheng.zong@outlook.com>
What this PR does / why we need it?
This guideline improves onboarding for new contributors and reduces ambiguity for maintainers when triaging issues.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Check content locally and maintainer can review via github preview, also need check the result of readthedocs CI workflow.