Skip to content

[Feat] Valkey vector store implementation#1671

Draft
daric93 wants to merge 1 commit intovllm-project:mainfrom
daric93:feature/valkey-vector-store
Draft

[Feat] Valkey vector store implementation#1671
daric93 wants to merge 1 commit intovllm-project:mainfrom
daric93:feature/valkey-vector-store

Conversation

@daric93
Copy link
Contributor

@daric93 daric93 commented Mar 27, 2026

Closes #1611

Summary

Adds Valkey as a vector store backend using the valkey-search module, enabling the system to run entirely on Valkey (when memory is disabled).

Implementation

  • ValkeyBackend struct implements the VectorStoreBackend interface (CreateCollection, DeleteCollection, CollectionExists, InsertChunks, DeleteByFileID, Search, Close)
  • Uses valkey-glide Go client with CustomCommand for all FT.* search operations (FT.CREATE, FT.SEARCH, FT.DROPINDEX, FT.INFO)
  • Coexists with existing vector store backends (memory, milvus, llama_stack) via the factory in factory.go

Validation

  • Added unit and integration tests.
  • Added CI configuration to run integration tests against a Valkey instance with the valkey-search module.
  • Tested locally with make test-valkey-vectorstore-external and make run-valkey-example-external.

Signed-off-by: Daria Korenieva <daric2612@gmail.com>
@netlify
Copy link

netlify bot commented Mar 27, 2026

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit fcf8e55
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/69c5d3f237a5e8000868b8f4
😎 Deploy Preview https://deploy-preview-1671--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

🚨 Supply Chain Security Report — Issues Found

Scanner Status Findings
AST Codebase Scan (Py, Go, JS/TS, Rust) 🚨 No issues detected
AST PR Diff Scan 🚨 No issues detected
Regex Fallback Scan No issues detected

Action required: CRITICAL and HIGH severity findings must be resolved before merge.


Scanned at 2026-03-27T00:49:03.718Z · View full workflow logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: Valkey vector store backend

1 participant