Skip to content

Load validate-target instead of package#206

Open
rtritto wants to merge 1 commit intovlitejs:mainfrom
rtritto:load-validate-target
Open

Load validate-target instead of package#206
rtritto wants to merge 1 commit intovlitejs:mainfrom
rtritto:load-validate-target

Conversation

@rtritto
Copy link
Copy Markdown
Contributor

@rtritto rtritto commented Mar 22, 2026

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

VliteJS is a 0 dependency library as described in the README.md.
The code of validate-target package can be easily used directly by file instead of install it by package.

Advantages

  • reduce size
  • reduce network usage
  • reduce bundle time

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 22, 2026

@rtritto is attempting to deploy a commit to the Vlitejs Team on Vercel.

A member of the Team first needs to authorize it.

@rtritto rtritto force-pushed the load-validate-target branch from 0d6ef11 to 6af6d51 Compare March 22, 2026 22:24
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vlite Ready Ready Preview Mar 25, 2026 5:48am

@yoriiis
Copy link
Copy Markdown
Member

yoriiis commented Mar 25, 2026

@rtritto I generally used libs from NPM directly and prevent not to duplicate the content, for easy maintenance and security fix. But I do understand also the "no dependency" here..

So we can go for it.

Please use the same content for clarity (I've don't check yet)

@rtritto
Copy link
Copy Markdown
Contributor Author

rtritto commented Mar 25, 2026

@rtritto I generally used libs from NPM directly and prevent not to duplicate the content, for easy maintenance and security fix. But I do understand also the "no dependency" here..

You can also maintain the original repository.
The security checks are also enable to this repository.

Please use the same content for clarity (I've don't check yet)

I did the copy-paste from the source and then added the link reference


WDYT about to rename the file from validate-target to validateTarget?

@yoriiis
Copy link
Copy Markdown
Member

yoriiis commented Apr 1, 2026

You can also maintain the original repository.
The security checks are also enable to this repository.

I'll do that, but with this change, I'll have to make the changes in both the original project and here

WDYT about to rename the file from validate-target to validateTarget?

The project uses a hyphen as a separator; I would prefer that we stick to this convention

@rtritto
Copy link
Copy Markdown
Contributor Author

rtritto commented Apr 1, 2026

I'll do that, but with this change, I'll have to make the changes in both the original project and here

Yes, I think that changes of validate-target should be less frequent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants