checker: resolve @VROOT in #flag pseudo-variable expansion#26714
Open
watzon wants to merge 2 commits intovlang:masterfrom
Open
checker: resolve @VROOT in #flag pseudo-variable expansion#26714watzon wants to merge 2 commits intovlang:masterfrom
watzon wants to merge 2 commits intovlang:masterfrom
Conversation
watzon
force-pushed
the
fix/vdoc-not-working-on-sequoia
branch
from
45dab60 to
bfae059
Compare
Collaborator
|
Bouncing to force CI to re-run. |
JalonSolov
reviewed
Mar 21, 2026
| c.error(err.msg(), pos) | ||
| return none | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
While this is a good idea, it doesn't solve the problem of source having @VROOT, as it only replaces after the source has been read.
Instead, the compiler should give an error message if @VROOT is used, and suggest running v fmt to fix the problem.
Of course, this also means that vfmt.v will need to be modified to make that substitution, if it doesn't already do so.
medvednikov
force-pushed
the
master
branch
2 times, most recently
from
cdf4550 to
4dc97d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
v docfailing against stale external tool dependencies.The original failure came from
vdocrecompiling against an outdated localmarkdownmodule checkout that still used deprecated@VROOTpaths for itsmd4cthird-party objects. Themarkdownmodule has already fixed thatupstream, so this patch does not restore
@VROOThandling in the compiler.Instead, it makes tool recompilation refresh external module dependencies before
building the tool binary. That allows
v docto pick up the currentvlang/markdownsources, which already use non-deprecated paths.Fixes #26698.