Make the budle start level property configurable, not hardcoded.#2
Open
dmitryintel wants to merge 1 commit intovivosys:masterfrom
Open
Make the budle start level property configurable, not hardcoded.#2dmitryintel wants to merge 1 commit intovivosys:masterfrom
dmitryintel wants to merge 1 commit intovivosys:masterfrom
Conversation
dmitryintel
commented
Mar 27, 2018
dmitryintel
commented
- Bundles below this start level are ignored.
- System property "com.vivosys.min.startlevel.depends.graph" used to configure the minimal start level
- Default value of 1 is used.
* Bundles below this start level are ignored.
rocketraman
reviewed
Apr 20, 2018
| } | ||
| } | ||
| logger.info("Building deps graph for start levels {} or above", retVal); | ||
| return retVal; |
Member
There was a problem hiding this comment.
Thanks for your contribution!
I prefer a coding style without the single-return retVal in general, see https://softwareengineering.stackexchange.com/questions/118703/where-did-the-notion-of-one-return-only-come-from. Please update accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.