feat(breakingchange): ✨ add breaking change configuration#101
feat(breakingchange): ✨ add breaking change configuration#101yi-Xu-0100 wants to merge 1 commit intovivaxy:masterfrom
Conversation
|
The beta extension of this pull has been built in the workflow! 🎉 |
vivaxy
left a comment
vivaxy
left a comment
There was a problem hiding this comment.
👍 That's a lot work done here. I'd like to test it for some time.
|
@vivaxy I test many times today and will use it in the future for some time. During the test, I found the bug (#100). I try to delete the export function and use the constructor in the prompt function to fix the bug. I do not why it can work, but it fixes the issue. Maybe we can make this little commit merge into master and make a patch firstly. See more in (#100) and the commit (326c953). 😀 |
package.nls.json
Outdated
| "extension.sources.prompt.breakingChange.placeholder": "Select a way to add breaking changes of this change.", | ||
| "extension.sources.prompt.breakingChange.noneItem.label": "None", | ||
| "extension.sources.prompt.breakingChange.noneItem.detail": "No breaking change.", | ||
| "extension.sources.prompt.breakingChange.pointItem.label": "! (point mode)", |
There was a problem hiding this comment.
Maybe it can be called as Breaking change in header.
There was a problem hiding this comment.
! exclamation mark (英式英语) / point (美式英语)
I misunderstood it. The exclamation point may be correct. 😅
I will use Breaking change in header, Breaking change in footer and Breaking change as token in footer for the labels of them.
Maybe because |
1. add `detectBreakingChange` option. 2. add `promptBreakingChange` option. 3. add two `breakingChangeFormat`.
yi-Xu-0100
force-pushed
the
add-breaking-change-prompt
branch
from
a42c75b to
21f24f5
Compare
|
Any chance of this getting merged someday ? |
|
Please add this feature |
|
👋 @silopolis @vladly I'm glad you noticed this issue. It hasn't been updated in a long time, and fixing it will require some time. Currently, I don't have the leisure time to address this problem. If you have any ideas, you can submit a pull request to help with the development. 😊 Moreover, due to the long-term use of the extension, frequent commits with disruptive changes are unreasonable. Therefore, this pull request has been put on hold and considered a low-priority feature. 🤔 |
|
Hello, if I understand correctly, this change will autmoatically add "BREAKING CHANGE: " when the user enters their breaking change into this prompt?
If so, this would be an amazing feature! I actually expected it to work like that already, and I thought something might be wrong with my configs. |
|
Hi, is this going to be merged soon? |
|
As this is part of Conventional Commits as a schema BREAKING CHANGE is a mandatory feature to be in line with the defaults. I would not consider this as a low prio feature. With this extension no major release would be possible if not done manual |
7 participants
detectBreakingChangeoption.promptBreakingChangeoption.breakingChangeFormatoption.close #39, close #100