Skip to content

Add progress bars for URL parsing and downloading from text files#296

Open
tmeier-lang wants to merge 3 commits intovitiko98:masterfrom
tmeier-lang:progress-bar-file
Open

Add progress bars for URL parsing and downloading from text files#296
tmeier-lang wants to merge 3 commits intovitiko98:masterfrom
tmeier-lang:progress-bar-file

Conversation

@tmeier-lang
Copy link

Changes

  • Added two progress bars to improve user feedback when downloading from text files:

    1. Progress bar for parsing URLs from the input file
    2. Progress bar for processing/downloading URLs
  • Added comprehensive test coverage:

    • Tests for file parsing with comments
    • Tests for empty file handling
    • Tests for error cases (file not found)
    • Tests for progress bar functionality
    • Tests for URL processing counts

Implementation Details

  • Uses tqdm for visual progress indication
  • Shows progress for both file parsing and URL processing phases
  • Handles comments and empty lines gracefully
  • Provides unit count (lines/URLs) and processing speed

Testing

Added test suite in tests/test_core.py covering:

  • Progress bar display and functionality
  • File parsing with comments
  • Empty file handling
  • File not found errors
  • URL processing verification

tmeier-lang added 3 commits May 13, 2025 14:47
- Add progress bar display tests with tqdm mocking
- Test URL parsing from files with comments
- Test empty file handling
- Test file not found error case
- Add proper cleanup with tempfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant