Add progress bars for URL parsing and downloading from text files#296
Open
tmeier-lang wants to merge 3 commits intovitiko98:masterfrom
Open
Add progress bars for URL parsing and downloading from text files#296tmeier-lang wants to merge 3 commits intovitiko98:masterfrom
tmeier-lang wants to merge 3 commits intovitiko98:masterfrom
Conversation
added 3 commits
May 13, 2025 14:47
- Add progress bar display tests with tqdm mocking - Test URL parsing from files with comments - Test empty file handling - Test file not found error case - Add proper cleanup with tempfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added two progress bars to improve user feedback when downloading from text files:
Added comprehensive test coverage:
Implementation Details
tqdmfor visual progress indicationTesting
Added test suite in
tests/test_core.pycovering: