Open
Conversation
This patch adds support for a HTTP proxy to the geeknote oauth authorization code. The proxy is read from system settings, usually the environment variable https_proxy. Basic proxy authorization is supported. Note that for geeknote to work through a proxy, proxy support for thrift needs to be enabled, too. See https://issues.apache.org/jira/browse/THRIFT-3798
The previous code wouldn't see the changed sys.stdout in printLine(). This way it works better.
The conversion has been broken since be00692. That patch divided the timestamp effectively by 1000 twice.
Take account of the fact that evernote measures time in milliseconds since 1.1.1970. Together with the previous commit, this fixes the test failure in test_print_date().
printList() and searchResult() use 18-character wide date fields. outTest hasn't been adapted to this until now.
This must be an assertRaises test.
The output was wrong by one \n.
Author
|
Oops, I forgot to leave out the first two patches (db3d, b9f2) from this pull request. They were already included in my previous pull request #355. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Vitaliy,
The current code fails many unit tests. These patches fix all tests for me (Linux 64bit, python 2.7.8). Moreover, they fix the broken date display in geeknote which has been caused by the wrong patch
be00692.
Regards
Martin