Skip to content

🎨 Palette: Improve navigation accessibility with ARIA labels #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vireapp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Improve navigation accessibility with ARIA labels #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2026-02-25 - Icon-Only Navigation Accessibility
**Learning:** The `MobileNav` component used `Link` with only icons and decorative elements, relying on visual cues (color/icon) but lacking accessible names. This renders the primary navigation unusable for screen reader users on mobile. Similar pattern found in `DashboardLayout` header buttons which used `title` but lacked `aria-label`.
**Action:** Always verify icon-only interactive elements (links/buttons) have `aria-label` or `sr-only` text, especially in critical navigation components.
2 changes: 2 additions & 0 deletions src/app/dashboard/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ export default async function DashboardLayout({
size="icon"
asChild
title="Settings"
aria-label="Settings"
className="hover:bg-muted hover:text-foreground rounded-full w-9 h-9 md:w-10 md:h-10"
>
<Link href="/dashboard/settings">
Expand All @@ -92,6 +93,7 @@ export default async function DashboardLayout({
size="icon"
type="submit"
title="Logout"
aria-label="Logout"
className="hover:bg-red-500/20 hover:text-red-400 rounded-full transition-colors w-9 h-9 md:w-10 md:h-10"
>
<LogOut className="w-5 h-5 md:w-4 md:h-4" />
Expand Down
1 change: 1 addition & 0 deletions src/components/mobile-nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ export function MobileNav() {
<Link
key={item.href}
href={item.href}
aria-label={item.title}
className="relative flex flex-col items-center justify-center w-12 h-12 sm:w-14 sm:h-14 rounded-xl"
>
{/* Active Background Pill */}
Expand Down