Skip to content

Conversation

@dfinkel
Copy link

@dfinkel dfinkel commented Dec 16, 2025

Since this was only accessed via a go.mod replace directive, it worked
fine for tests, etc. running in galaxycache's repo, but, since the
replace directive doesn't propagate outside the original repo, go
commands doing deep resolution complain because they can't resolve the
zero-valued version.

Note: Since the dependency on peercfg is only via tests, this didn't
actually affect building anything depending on Galaxycache, just
commands like that run by GoLand at startup:

go list -modfile=go.mod -m -json -mod=mod all

Since this was only accessed via a go.mod replace directive, it worked
fine for tests, etc. running in galaxycache's repo, but, since the
replace directive doesn't propagate outside the original repo, go
commands doing deep resolution complain because they can't resolve the
zero-valued version.

Note: Since the dependency on peercfg is only via tests, this didn't
actually affect building anything depending on Galaxycache, just
commands like that run by GoLand at startup:
```sh
go list -modfile=go.mod -m -json -mod=mod all
```
@dfinkel dfinkel merged commit 56f98b8 into master Dec 16, 2025
8 checks passed
@dfinkel dfinkel deleted the compattest_peercfg_real_version branch December 16, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants