fix: abbrevモードでのキャンセル後にモードをhiraに戻す - #242
Merged
Merged
Conversation
cancel()はinitializeState()を直接呼んでいたため、state.modeは
"direct"にリセットされるがmodeChange()は呼ばれず、context.mode
（およびvim.g["skkeleton#mode"]）が"abbrev"のまま残るバグがあった。
initializeStateWithAbbrev()を使うよう変更することで、abbrevモードから
抜ける際にmodeChange("hira")が呼ばれ、表示上のモードが正しく同期される。
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
ありがとうございます！ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題
cancel()（<C-g>キー）がinitializeState()を直接呼んでいたため、state.modeは"direct"にリセットされますがmodeChange()は呼ばれません。その結果、abbrevモードで
<C-g>キャンセルした後もcontext.modeおよびvim.g["skkeleton#mode"]が"abbrev"のまま残るバグがありました。修正
initializeStateWithAbbrev()を使うよう変更することで、abbrevモードから抜ける際にmodeChange("hira")が呼ばれ、表示上のモードが正しく同期されます。これは
kakutei()が既にinitializeStateWithAbbrev()を使っているのと同じ対応です。