fix: correct ARIA expanded and activedescendant states for menu buttons#9172
Open
karthikeyansundaram2 wants to merge 1 commit intovideojs:mainfrom
Open
fix: correct ARIA expanded and activedescendant states for menu buttons#9172karthikeyansundaram2 wants to merge 1 commit intovideojs:mainfrom
karthikeyansundaram2 wants to merge 1 commit intovideojs:mainfrom
Conversation
When navigating the Chapters or Captions menus with a screen reader, the and attributes were not being updated correctly. This broke keyboard navigation and caused confusion for assistive technology users. This commit fixes the issue by: - Setting when the menu is shown (on hover or press) - Setting and removing when the menu is hidden - Pointing to the ID of the currently focused menu item Fixes videojs#7688
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7688
Problem
When navigating the Chapters or Captions menus with a screen reader, the
aria-expandedandaria-activedescendantattributes were not being updated correctly. This broke keyboard navigation and caused confusion for assistive technology users.Fix
This commit fixes the issue by:
aria-expanded='true'when the menu is shown (on hover or press)aria-expanded='false'and removingaria-activedescendantwhen the menu is hiddenaria-activedescendantto the ID of the currently focused menu itemThis ensures screen readers accurately reflect the menu's state and which item is currently selected.