Skip to content

Fix front camera default and camera switching #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
victorges wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix front camera default and camera switching #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 41 additions & 1 deletion src/pages/Capture.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,15 @@ export default function Capture() {
}, []);

const selectCamera = useCallback(async (type: 'front' | 'back') => {
// If switching cameras while stream is active, stop current stream first
if (cameraType && cameraType !== type) {
console.log(`Switching camera from ${cameraType} to ${type}`);
stopAllMediaStreams();
setPlaybackId(null);
setStreamId(null);
setIsPlaying(false);
}

setCameraType(type);
const randomPrompt = type === 'front'
? FRONT_PROMPTS[Math.floor(Math.random() * FRONT_PROMPTS.length)]
Expand All @@ -227,7 +236,7 @@ export default function Capture() {

// Pass the initial prompt to initializeStream
await initializeStream(type, randomPrompt);
}, [initializeStream]);
}, [initializeStream, cameraType, stopAllMediaStreams]);

// Auto-start camera on desktop (non-mobile devices)
useEffect(() => {
Expand Down Expand Up @@ -886,6 +895,22 @@ export default function Capture() {
)}
</Button>
</div>

{/* Camera Switch Button - only show on mobile devices with multiple cameras */}
{hasMultipleCameras() && (
<div className="absolute top-3 right-3">
<Button
onClick={() => selectCamera(cameraType === 'front' ? 'back' : 'front')}
disabled={loading}
size="icon"
variant="secondary"
className="w-12 h-12 rounded-full shadow-lg transition-all duration-200 bg-neutral-800 hover:bg-neutral-700 text-neutral-200"
title={`Switch to ${cameraType === 'front' ? 'back' : 'front'} camera`}
>
<Camera className="w-5 h-5" />
</Button>
</div>
)}
</div>
</div>

Expand Down Expand Up @@ -938,6 +963,21 @@ export default function Capture() {

{/* Controls */}
<div className="bg-neutral-950 rounded-3xl p-5 border border-neutral-800 space-y-4 shadow-inner">
{/* Camera Switch Button - only show on mobile devices with multiple cameras */}
{hasMultipleCameras() && (
<div className="flex justify-center">
<Button
onClick={() => selectCamera(cameraType === 'front' ? 'back' : 'front')}
disabled={loading}
variant="outline"
className="bg-neutral-900 border-neutral-800 hover:border-neutral-600 hover:bg-neutral-850 text-neutral-200"
>
<Camera className="w-4 h-4 mr-2" />
Switch to {cameraType === 'front' ? 'Back' : 'Front'} Camera
</Button>
</div>
)}

<div>
<label className="text-sm font-medium mb-2 block text-neutral-300">Prompt</label>
<div className="flex items-start gap-2">
Expand Down