You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks like now instead of taking a graph file with just the path(s) and no nodes, and combining it into a base graph, you're taking a graph file with the path and all the nodes, and combining it into the base graph that also has the nodes. Since vg combine says it will re-number nodes in the graphs being combined to avoid conflicts, it sounds like you're going to end up with graphs files with two whole copies of the graph in them, one of which has the path(s).
I think you want to drop the vg combine and just have vg paths --retain-paths write directly to the file that vg combine was going to write.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is why vgteam/vg#4846 was failing tests.