fix(ai): pass abortSignal to reconnectToStream so stop() works after resumeStream()#14350
Open
ericallam wants to merge 1 commit intovercel:mainfrom
Open
fix(ai): pass abortSignal to reconnectToStream so stop() works after resumeStream()#14350ericallam wants to merge 1 commit intovercel:mainfrom
ericallam wants to merge 1 commit intovercel:mainfrom
Conversation
…resumeStream() Previously, `stop()` had no effect after calling `resumeStream()` because the AbortController was created after `reconnectToStream()` returned, and `reconnectToStream` didn't accept an `abortSignal` parameter. This meant the abort signal was never connected to the resumed stream. This fix: 1. Creates the AbortController before calling `reconnectToStream()` 2. Adds `abortSignal` to the `ChatTransport.reconnectToStream` interface 3. Passes the signal through in `HttpChatTransport.reconnectToStream` 4. Adds tests verifying stop() works correctly on resumed streams
tigent
bot
added
ai/ui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When a user calls
resumeStream()(e.g. to reconnect to an active chat after a page refresh), thestop()method has no effect. This is because theAbortControlleris created afterreconnectToStream()returns, so the abort signal is never connected to the resumed stream.Summary
AbortControllerbefore callingreconnectToStream()inmakeRequestabortSignalparameter to theChatTransport.reconnectToStreaminterfaceHttpChatTransport.reconnectToStream(to thefetchcall)stop()works correctly on resumed streamsChecklist
stop should abort a resumed stream— 4 test cases)