Conversation
The second insert into a table with all fixed-size columns (e.g. Uint64 + Uint64 + 1-byte CustomDataType) failed with OffsetNotAligned because: 1. table_registry::insert aligned the write offset using E::ALIGNMENT instead of RawRecord<E>::ALIGNMENT (which includes the 2-byte header). 2. page_ledger::commit double-wrapped the type in RawRecord, computing RawRecord<RawRecord<E>>::ALIGNMENT instead of RawRecord<E>::ALIGNMENT, causing incorrect free-space tracking. Closes #80
|
✔️ 5179c7d...e5b8710 - Conventional commits check succeeded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OffsetNotAlignederror when inserting a second record into tables with all fixed-size columns (e.g.Uint64 + Uint64 + 1-byte CustomDataType)table_registry::insertaligned write offset usingE::ALIGNMENTinstead ofRawRecord<E>::ALIGNMENT, andpage_ledger::commitdouble-wrapped the type computingRawRecord<RawRecord<E>>::ALIGNMENTinstead ofRawRecord<E>::ALIGNMENTCloses #80
Test plan
test_should_insert_multiple_fixed_size_recordspassesjust test)just clippy)🤖 Generated with Claude Code