Set Demo and Utility RPATHs to match system defaults
#291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marius Behrens <marius.behrens@synopsys.com>
Signed-off-by: Marius Behrens <marius.behrens@synopsys.com>
Signed-off-by: Marius Behrens <marius.behrens@synopsys.com>
Signed-off-by: Marius Behrens <marius.behrens@synopsys.com>
snps-behrens
force-pushed
the
install_rpath
branch
from
a67cf8a to
2fe1585
Compare
snps-behrens
changed the title
RPATHs to match sytem defaultsRPATHs to match system defaults
VJanKraemer
requested review from
VJanKraemer
and removed request for
MariusBgm
VJanKraemer
approved these changes
Jan 22, 2026
Contributor
VJanKraemer
left a comment
VJanKraemer
left a comment
There was a problem hiding this comment.
Looks good to me and congratulations on your first PR 🥳
Please squash the commits before merging and I think the PR title would also be a good, descriptive commit msg header. Any additional info should be in the msg body.
snps-behrens
commented
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a SIL Kit installation is built, the system default is used to name the lib-directory in the install hierarchy. On certain Linux distributions (Alma Linux, for instance) this default lib-directory is
lib64instead oflib. This results in the SIL Kit Demos and Utilities not being able to findlibSilKit.sobecause their RPATH is hard-coded to uselib.This PR proposes setting these
RPATHs to match the naming scheme used when creating the SIL Kit installation (as defined by theGNUInstallDirsCMake module).Developer checklist (address before review)