Generics for nodes and links in typescript#359
Open
fxhm wants to merge 1 commit intovasturiano:masterfrom
Open
Generics for nodes and links in typescript#359fxhm wants to merge 1 commit intovasturiano:masterfrom
fxhm wants to merge 1 commit intovasturiano:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a generic version of
ForceGraphandForceGraphInstance:type TypedForceGraphInstance<N extends NodeObject, L extends TypedLinkObject<N>>and
function TypedForceGraph<N extends NodeObject, L extends TypedLinkObject<N>>(): TypedForceGraphInstance<N, L>The types
ForceGraphandForceGraphInstanceare kept for backwards compatibility.Reason
One might want to access custom properties of your own node and link objects in the graphs accessor functions.
Typescript won't let you do that without errors/warnings if there the type is fixed to
NodeObject/LinkObject.Example usage