ci: unify preview and release into a single workflow#7
Merged
Conversation
Merge preview.yml into release.yml as a second job so all publishing happens from one workflow file (needed for npm trusted publishing / provenance, which is bound to the workflow filename). Gate each job by event: 'release' runs on push to main (changesets version PR / publish), 'preview' runs on qualifying pull requests. Previously the release job had no event guard and would also fire on PRs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Contributor
Preview releaseLatest commit: Some packages have been released:
Note Use the PR number as tag to install any package. For instance: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Unify
preview.ymlandrelease.ymlinto a singlerelease.ymlso all publishing happens from one workflow file — required because npm trusted publishing / provenance is bound to the workflow filename, and the split meant onlypreview.ymlmatched it.preview.ymldeleted; its job moved intorelease.ymlas thepreviewjob.releaseruns only onpushtomain;previewruns only on qualifyingpull_requests. Before, thereleasejob had no event guard and would also fire on every PR (minting the bot token + running changesets on PRs).Still needed on the npm side (not in this PR)
@vlandoss/theme-togglefrompreview.yml→release.yml.NPM_TOKENremoved from thereleasejob. Node ≥ 22.14.0 is already satisfied by the 24.16.0 pin.The
releasejob currently keepsNPM_TOKENas a functional baseline; tell me which auth model you want and I'll finalize it.🤖 Generated with Claude Code