More hydra gtk by elboulangero · Pull Request #1047 · vanhauser-thc/thc-hydra

elboulangero · 2025-11-21T04:25:33Z

No description provided.

As gtk_hbox and gtk_vbox are deprecated

The new autogen.sh was copied from https://wiki.gnome.org/Projects/GnomeCommon/Migration Then some files were updated to today's standard, so that at this point, running ./autogen.sh doesn't spit out any warning.

Alternative would be to drop all those files entirely

This is something that distributions (at least Debian) has to patch, because we want to be notified if something fails to build, we don't want that a part of the package fails to build silently. Looking at pw-inspector, it's a small C programm with no dependency, so why would it fail to build anyway? xhydra build is already conditioned by XHYDRA_SUPPORT: users who don't want it can just build in a environment without GTK, if ever for some reason it fails to build.

Following the logic of the last commit: no need to let it fail silently or to wrap commands, hide output, etc etc... Just run the standard commands, that's it.

vanhauser-thc · 2025-11-21T10:04:18Z

Makefile.am


 xhydra:	
-	-cd hydra-gtk && sh ./make_xhydra.sh
+	cd hydra-gtk && sh ./make_xhydra.sh


if xhydra cannot be built then this should not result in a build failure. not everyone has gtk installed.

If you don't have GTK devel files installed, the build of xhydra is just skipped, per:

thc-hydra/Makefile.am

Line 51 in e92ccfd

all: pw-inspector hydra $(XHYDRA_SUPPORT)

XHYDRA_SUPPORT can be disabled manually:

thc-hydra/configure

Lines 108 to 113 in e92ccfd

if [ "X" = "X$XHYDRA_SUPPORT" ]; then

XHYDRA_SUPPORT_TMP=`echo "$1"|sed 's/.*--disable-xhydra//'`

if [ -z "$XHYDRA_SUPPORT_TMP" ]; then

XHYDRA_SUPPORT="disable"

fi

fi

Otherwise it's automatically set:

thc-hydra/configure

Lines 1332 to 1345 in e92ccfd

if [ "X" = "X$XHYDRA_SUPPORT" ]; then

echo "Checking for GUI req's (pkg-config/gtk+-3.0) ..."

XHYDRA_SUPPORT=`$PKG_CONFIG --help > /dev/null 2>&1 || echo disabled`

if [ "X" = "X$XHYDRA_SUPPORT" ]; then

XHYDRA_SUPPORT=`$PKG_CONFIG --modversion gtk+-3.0 2> /dev/null`

else

XHYDRA_SUPPORT=""

fi

if [ "X" = "X$XHYDRA_SUPPORT" ]; then

echo " ... NOT found, optional anyway"

else

echo " ... found"

fi

fi

Tell me if I'm missing something

hmm well, let's try it if too many people complain then it can still be made optional again

Sure, don't hesitate to ping me if something comes out!

vanhauser-thc · 2025-11-21T10:04:49Z

looks good, left one comment. thanks!

elboulangero · 2025-11-21T11:06:19Z

Also, I wanted to comment on this commit from this MR: 7b2c625

Personally, I'd be in favor of dropping all these generated files (that nobody is going to review), which means that users who want to build it HAVE TO run the ./autogen,sh script (which basically runs autoreconf). I don't think that it's going to be a problem for anyone.

I have no idea what's the "state of art" in this regard, I switched to meson long ago for GTK apps, as did much of the GNOME ecosystem. Looking for an example of a "modern" GTK app that still use autoreconf, I could find the 2.x branch of GIMP, and they don't commit those auto-generated files either: https://github.com/GNOME/gimp/tree/gimp-2.10.

So I'd prefer to drop all these files if that's Ok with you.

vanhauser-thc · 2025-11-21T11:18:51Z

Also, I wanted to comment on this commit from this MR: 7b2c625

Personally, I'd be in favor of dropping all these generated files (that nobody is going to review), which means that users who want to build it HAVE TO run the ./autogen,sh script (which basically runs autoreconf). I don't think that it's going to be a problem for anyone.

I have no idea what's the "state of art" in this regard, I switched to meson long ago for GTK apps, as did much of the GNOME ecosystem. Looking for an example of a "modern" GTK app that still use autoreconf, I could find the 2.x branch of GIMP, and they don't commit those auto-generated files either: https://github.com/GNOME/gimp/tree/gimp-2.10.

So I'd prefer to drop all these files if that's Ok with you.

sure then drop them

Also update .gitignore to not commit those files again

elboulangero · 2025-11-21T16:00:12Z

Dropped the generated files and pushed last minor changes

vanhauser-thc · 2025-11-22T10:13:27Z

thanks!

vanhauser-thc · 2025-11-22T10:18:45Z

I noticed that the autconfigure stuff now modifies the hydra-gtk/INSTALL file

elboulangero · 2025-11-22T12:56:39Z

hydra-gtk/INSTALL yes it's a auto-generated file, I thought that it would be nice to keep it committed to the repo, in case someone wants to read it.

But then depending on what version of autoreconf you run, it will probably be slightly different...

So maybe best to remove it from the repo like all the other files? Agree with that?

vanhauser-thc · 2025-11-22T13:18:03Z

We could rename it to README.txt?

elboulangero · 2025-11-23T05:53:43Z

README-autoconf? I pushed it here: #1048

elboulangero added 6 commits November 21, 2025 11:23

hydra-gtk: Replace gtk_hbox and gtk_vbox with gtk_box

ae1a908

As gtk_hbox and gtk_vbox are deprecated

hydra-gtk: Add -Wno-deprecated-declarations

0b8de66

hydra-gtk: Modernize the autoconf machinery

b60fbf1

The new autogen.sh was copied from https://wiki.gnome.org/Projects/GnomeCommon/Migration Then some files were updated to today's standard, so that at this point, running ./autogen.sh doesn't spit out any warning.

hydra-gtk: Update autogenerated files

7b2c625

Alternative would be to drop all those files entirely

hydra-gtk: Reduce make_hydra.sh to the minimum

1174cf4

Following the logic of the last commit: no need to let it fail silently or to wrap commands, hide output, etc etc... Just run the standard commands, that's it.

vanhauser-thc reviewed Nov 21, 2025

View reviewed changes

elboulangero added 3 commits November 21, 2025 22:46

hydra-gtk: Remove all autoconf-generated files

794a6ed

Also update .gitignore to not commit those files again

hydra-gtk: Run autogen.sh before configure

d9f5570

Update INSTALL file for GTK3

4fb9d72

elboulangero force-pushed the more-hydra-gtk branch from 1bd8fb2 to 4fb9d72 Compare November 21, 2025 16:30

hydra-gtk: Don't run configure twice

b346b0b

vanhauser-thc merged commit fbd8a1f into vanhauser-thc:master Nov 22, 2025
1 check failed

	if [ "X" = "X$XHYDRA_SUPPORT" ]; then
	XHYDRA_SUPPORT_TMP=`echo "$1"\|sed 's/.*--disable-xhydra//'`
	if [ -z "$XHYDRA_SUPPORT_TMP" ]; then
	XHYDRA_SUPPORT="disable"
	fi
	fi

	if [ "X" = "X$XHYDRA_SUPPORT" ]; then
	echo "Checking for GUI req's (pkg-config/gtk+-3.0) ..."
	XHYDRA_SUPPORT=`$PKG_CONFIG --help > /dev/null 2>&1 \|\| echo disabled`
	if [ "X" = "X$XHYDRA_SUPPORT" ]; then
	XHYDRA_SUPPORT=`$PKG_CONFIG --modversion gtk+-3.0 2> /dev/null`
	else
	XHYDRA_SUPPORT=""
	fi
	if [ "X" = "X$XHYDRA_SUPPORT" ]; then
	echo " ... NOT found, optional anyway"
	else
	echo " ... found"
	fi
	fi

Conversation

elboulangero commented Nov 21, 2025

Uh oh!

vanhauser-thc Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

elboulangero Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

vanhauser-thc Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

elboulangero Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

vanhauser-thc commented Nov 21, 2025

Uh oh!

elboulangero commented Nov 21, 2025

Uh oh!

vanhauser-thc commented Nov 21, 2025

Uh oh!

elboulangero commented Nov 21, 2025

Uh oh!

vanhauser-thc commented Nov 22, 2025

Uh oh!

Uh oh!

vanhauser-thc commented Nov 22, 2025

Uh oh!

elboulangero commented Nov 22, 2025

Uh oh!

vanhauser-thc commented Nov 22, 2025

Uh oh!

elboulangero commented Nov 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants