fix(test): use absolute paths for test data files#50
Open
vanadium23 wants to merge 4 commits intomainfrom
Open
fix(test): use absolute paths for test data files#50vanadium23 wants to merge 4 commits intomainfrom
vanadium23 wants to merge 4 commits intomainfrom
Conversation
Owner
vanadium23
commented
Mar 20, 2026
vanadium23
commented
- Changed relative paths to absolute paths using runtime.Caller
- Fixed koreader_test.go MD5 comparison (string vs hex formatting)
- Simplified metadata_test.go to compare only essential fields
- Tests now work correctly when run from project root
- Changed relative paths to absolute paths using runtime.Caller - Fixed koreader_test.go MD5 comparison (string vs hex formatting) - Simplified metadata_test.go to compare only essential fields - Tests now work correctly when run from project root Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Added expected description with typographic quotes (U+201C, U+201D) and apostrophe (U+2019) to match actual metadata extracted from the EPUB file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Re-added Cover image comparison using reference files from test_data/covers/ and ISBN field validation. FB2 description skipped due to mojibake in test file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Restored original test structure with all fields validated: - Title, Author, Format for all formats - Description with typographic quotes for EPUB - Description with mojibake characters for FB2 (matches file content) - Cover images loaded from test_data/covers/ - ISBN for EPUB Fixed relative path issues by using runtime.Caller(0) for absolute paths. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.