feat(modal): add container option to append modals to custom elements#6749
Open
valorkin wants to merge 3 commits intodevelopmentfrom
Open
feat(modal): add container option to append modals to custom elements#6749valorkin wants to merge 3 commits intodevelopmentfrom
valorkin wants to merge 3 commits intodevelopmentfrom
Conversation
- Add container option to ModalOptions (string selector or Element) - Update BsModalService to use custom container instead of hardcoded 'body' - Apply container option to both modal and backdrop components - Maintain backward compatibility with default 'body' container - Add comprehensive unit tests for container functionality - Add E2E tests to verify modal container behavior Fixes #731 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Deploying ngx-bootstrap with
|
| Latest commit: |
ed2bf70
|
| Status: | 🚫 Build failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code