Fix cleanup state timeouts (bsc#1258567)

[ycedres]

When a user deletes a system from the UI, the operation hangs for exactly 240 seconds (4 minutes). This was caused by the removal of the minion keys in the cleanup_minion state before returning the result of the execution to master.

The cleanup_minion state was refactored to perform an asynchronous clean up by first removing the keys and secondly stopping the salt minion service. This allows the state execution to return.

What does this PR change?

add description

Codespace

Check if you already have a running container clicking on

GUI diff

No difference.

Before:

After:

• DONE

Documentation

• No documentation needed: add explanation. This can't be used if there is a GUI diff

• No documentation needed: only internal and user invisible changes

• Documentation issue was created: Link for SUSE Multi-Linux Manager contributors, Link for community contributors.

• API documentation added: please review the Wiki page Writing Documentation for the API if you have any changes to API documentation.

• (OPTIONAL) Documentation PR

• DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

• No tests: add explanation

• No tests: already covered

• Unit tests were added

• Cucumber tests were added

• DONE

Links

Issue(s): #
Port(s): # add downstream PR(s), if any

• DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

• No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

• Re-run test "changelog_test"
• Re-run test "backend_unittests_pgsql"
• Re-run test "java_pgsql_tests"
• Re-run test "schema_migration_test_pgsql"
• Re-run test "susemanager_unittests"
• Re-run test "frontend_checks"
• Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!