Ensure directory exists before writing systemid#11447
Open
denyskon wants to merge 6 commits intouyuni-project:masterfrom
Open
Ensure directory exists before writing systemid#11447denyskon wants to merge 6 commits intouyuni-project:masterfrom
denyskon wants to merge 6 commits intouyuni-project:masterfrom
Conversation
aaannz
requested changes
Feb 6, 2026
Contributor
aaannz
left a comment
There was a problem hiding this comment.
Thank you for the contribution.
Can you adjust the changelog so it is wrapped at line length 67 characters? See the failed changelog test.
aaannz
previously approved these changes
Feb 6, 2026
Contributor
|
Can you also squash the commits please - ideally squash the 5 of your commits into one, and leave the black formatting commit from me separate. After that, we should be good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Ensure the directory /etc/sysconfig/rhn exists in proxy-httpd container before writing into it from the uyuni-config.py script. Prevents a crash on init of the proxy-httpd container due to missing directory.
GUI diff
No difference.
Documentation
Test coverage
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!