Skip to content

Ensure directory exists before writing systemid#11447

Open
denyskon wants to merge 6 commits intouyuni-project:masterfrom
denyskon:patch-1
Open

Ensure directory exists before writing systemid#11447
denyskon wants to merge 6 commits intouyuni-project:masterfrom
denyskon:patch-1

Conversation

@denyskon
Copy link

@denyskon denyskon commented Feb 6, 2026

What does this PR change?

Ensure the directory /etc/sysconfig/rhn exists in proxy-httpd container before writing into it from the uyuni-config.py script. Prevents a crash on init of the proxy-httpd container due to missing directory.

GUI diff

No difference.

Documentation

  • No documentation needed: only internal and user invisible changes

Test coverage

  • No tests: modifies the init script for the proxy-httpd container to fix a failure, no new functionality

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "frontend_checks"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@denyskon denyskon requested a review from a team as a code owner February 6, 2026 07:10
@denyskon denyskon requested review from ycedres and removed request for a team February 6, 2026 07:10
@m-czernek m-czernek requested a review from aaannz February 6, 2026 09:14
Copy link
Contributor

@aaannz aaannz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.

Can you adjust the changelog so it is wrapped at line length 67 characters? See the failed changelog test.

@denyskon denyskon requested a review from aaannz February 6, 2026 11:58
aaannz
aaannz previously approved these changes Feb 6, 2026
@m-czernek
Copy link
Contributor

Can you also squash the commits please - ideally squash the 5 of your commits into one, and leave the black formatting commit from me separate.

After that, we should be good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments