Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
==========================================
- Coverage 66.51% 66.32% -0.19%
==========================================
Files 36 36
Lines 4366 4380 +14
Branches 982 984 +2
==========================================
+ Hits 2904 2905 +1
- Misses 1062 1072 +10
- Partials 400 403 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
36d1a4c to
fe3e4d0
Compare
|
@hanbings do you have an update on this ? thanks :) |
fe3e4d0 to
18b88ff
Compare
| path_to_file.to_string_lossy() | ||
| ); | ||
| #[allow(clippy::explicit_write)] | ||
| write!(stdout(), "{}", tips).unwrap(); |
There was a problem hiding this comment.
POSIX specifies
- The -ok primary shall write a prompt to standard error
- In the POSIX locale, the last non-<blank> in the prompt shall be '?'
There was a problem hiding this comment.
Thanks! I overlooked these, I will fix them later.
|
@hanbings any plan to finish it ? thanks :) |
Yes, I’ll make sure to get them done, but the implementation is more challenging than it seems. I’ll need to free up some time, so I expect to be able to work on them in about one to two weeks. (same #411 (comment)) |
implement: #8