perf(split): optimize FixedWidthNumber Display implementation#10723
Draft
CrazyRoka wants to merge 1 commit intouutils:mainfrom
Draft
perf(split): optimize FixedWidthNumber Display implementation#10723CrazyRoka wants to merge 1 commit intouutils:mainfrom
CrazyRoka wants to merge 1 commit intouutils:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
Displayimplementation forFixedWidthNumbercollects all mapped digits into a temporaryStringbefore writing them to the formatter. This incurs an unnecessary heap allocation every time a number is formatted.This change replaces formatting logic with direct
write_charcalls with optimization in mind.