uucore: refactor digest_reader to use ReadingMode enum#10720
Open
0xMillyByte wants to merge 1 commit intouutils:mainfrom
Open
uucore: refactor digest_reader to use ReadingMode enum#107200xMillyByte wants to merge 1 commit intouutils:mainfrom
0xMillyByte wants to merge 1 commit intouutils:mainfrom
Conversation
0xMillyByte
force-pushed
the
refactor/digest-reader-reading-mode
branch
2 times, most recently
from
e2d0f1f to
4f51b53
Compare
0xMillyByte
force-pushed
the
refactor/digest-reader-reading-mode
branch
from
4f51b53 to
89bffa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactored
digest_readerto use theReadingModeenum for better readability. This allowed me to get rid of aTODOin the code.