Skip to content

syntax role modifiers#1835

Draft
jurgenvinju wants to merge 97 commits intomainfrom
syntax-role-modifiers
Draft

syntax role modifiers#1835
jurgenvinju wants to merge 97 commits intomainfrom
syntax-role-modifiers

Conversation

@jurgenvinju
Copy link
Copy Markdown
Member

@jurgenvinju jurgenvinju commented Jul 7, 2023

This PR implements syntax role modifiers.

SyntaxModifiers.pdf

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 7, 2023

Codecov Report

❌ Patch coverage is 9.40439% with 578 lines in your changes missing coverage. Please review.
✅ Project coverage is 46%. Comparing base (53d2faa) to head (d5fd3aa).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/org/rascalmpl/types/ModifySyntaxRole.java 0% 309 Missing ⚠️
src/org/rascalmpl/ast/SyntaxRoleModifier.java 0% 114 Missing ⚠️
...ascalmpl/semantics/dynamic/SyntaxRoleModifier.java 0% 27 Missing ⚠️
src/org/rascalmpl/ast/Type.java 21% 25 Missing ⚠️
src/org/rascalmpl/library/Type.java 33% 24 Missing ⚠️
src/org/rascalmpl/types/RascalTypeFactory.java 4% 21 Missing and 1 partial ⚠️
...org/rascalmpl/values/parsetrees/SymbolFactory.java 5% 16 Missing ⚠️
src/org/rascalmpl/ast/NullASTVisitor.java 0% 6 Missing ⚠️
...almpl/interpreter/staticErrors/UnexpectedType.java 25% 4 Missing and 2 partials ⚠️
src/org/rascalmpl/types/RascalType.java 0% 6 Missing ⚠️
... and 10 more
Additional details and impacted files
@@           Coverage Diff            @@
##              main   #1835    +/-   ##
========================================
- Coverage       46%     46%    -1%     
- Complexity    6737    6742     +5     
========================================
  Files          794     798     +4     
  Lines        65923   66562   +639     
  Branches      9888   10001   +113     
========================================
+ Hits         30858   30950    +92     
- Misses       32684   33221   +537     
- Partials      2381    2391    +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…s by calling the RascalTypeFactory and recursion on the single type parameter
… uses the new syntax for role modifiers too soon
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants