fix: advanced task environment argument shows deleted environments#4064
Open
rocketeerbkw wants to merge 1 commit intomainfrom
Open
fix: advanced task environment argument shows deleted environments#4064rocketeerbkw wants to merge 1 commit intomainfrom
rocketeerbkw wants to merge 1 commit intomainfrom
Conversation
Overview
|
bomoko
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Checklist
Database Migrations
n/a
Description
When defining an advanced task argument of type
ENV_VAR_NAME_SOURCEorENVIRONMENT_SOURCE_NAME_EXCLUDE_SELF, the returned list of environments included deleted environments. This results in a list with potentially a lot of duplicated items.Selecting any of the duplicates is valid, since the environment name is the most important part, but it can be confusing. This PR filters out deleted environments, since there isn't ever a reason to be able to select one.
Closing issues
n/a